[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

From: Marcel Apfelbaum
Subject: Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header
Date: Mon, 22 Feb 2021 10:33:20 +0200

Hi Jason.

On Tue, Feb 9, 2021 at 5:47 AM Jason Wang <jasowang@redhat.com> wrote:

On 2021/2/9 上午1:28, Paolo Bonzini wrote:
> On 08/02/21 18:17, Cornelia Huck wrote:
>> On Fri, 29 Jan 2021 16:27:19 +0100
>> Cornelia Huck <cohuck@redhat.com> wrote:
>>> On Fri, 22 Jan 2021 19:00:29 +0100
>>> Cornelia Huck <cohuck@redhat.com> wrote:
>>>> The pvrdma code relies on the pvrdma_ring.h kernel header for some
>>>> basic ring buffer handling. The content of that header isn't very
>>>> exciting, but contains some (q)atomic_*() invocations that (a)
>>>> cause manual massaging when doing a headers update, and (b) are
>>>> an indication that we probably should not be importing that header
>>>> at all.
>>>> Let's reimplement the ring buffer handling directly in the pvrdma
>>>> code instead. This arguably also improves readability of the code.
>>>> Importing the header can now be dropped.
>>>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>>> ---
>>>> Compile-tested only, needs both testing and more eyeballs :)
>>> Friendly ping :)
>>> Suggestions for a test setup to do some sanity checks (that does not
>>> require special hardware) also welcome.
>> Can I interest anyone in this? I'd be happy doing sanity tests myself,
>> but I have a hard time figuring out even where to start...
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Jason, Michael, are you going to pick this up?
> Paolo

I will queue this.

Have you picked it up? It will be great so I'll not send a PR with a single patch...
BTW, Yuval tested and acked the patch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]