[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] ui/cocoa: Remove the uses of full screen APIs
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2] ui/cocoa: Remove the uses of full screen APIs |
Date: |
Mon, 22 Feb 2021 11:30:05 +0100 |
Hi,
> The detections of [NSView -enterFullScreen:] and
> [NSView -exitFullScreen:] were wrong. A detection is coded as:
> [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)]
> but it should be:
> [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)]
>
> Because of those APIs were not detected, ui/cocoa always falled
> back to a borderless window whose frame matches the screen to
> implement fullscreen behavior.
>
> The code using [NSView -enterFullScreen:] and
> [NSView -exitFullScreen:] will be used if you fix the detections,
> but its behavior is undesirable; the full screen view stretches
> the video, changing the aspect ratio, even if zooming is disabled.
>
> This change removes the code as it does nothing good.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Added to UI queue.
thanks,
Gerd