[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hw/block/nvme: nvme_identify fixes
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/3] hw/block/nvme: nvme_identify fixes |
|
Date: |
Mon, 22 Feb 2021 14:13:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/22/21 1:00 PM, Minwoo Im wrote:
> On 21-02-22 08:06:13, Klaus Jensen wrote:
>> From: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>>
>> Remove an unnecessary le_to_cpu conversion and add trace event for
>> Identify.
>>
>> Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
>> ---
>> hw/block/nvme.c | 5 ++++-
>> hw/block/trace-events | 1 +
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
>> index 1cd82fa3c9fe..ddc83f7f7a19 100644
>> --- a/hw/block/nvme.c
>> +++ b/hw/block/nvme.c
>> @@ -3415,7 +3415,10 @@ static uint16_t nvme_identify(NvmeCtrl *n,
>> NvmeRequest *req)
>> {
>> NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>
>> - switch (le32_to_cpu(c->cns)) {
>> + trace_pci_nvme_identify(nvme_cid(req), c->cns, le16_to_cpu(c->ctrlid),
>> + c->csi);
>
> I think it would be great if it can be separated into two.
Agreed.
> Anyway, changes look good to me.
>
> Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>