[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v21 06/17] meson: add target_user_arch
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v21 06/17] meson: add target_user_arch |
Date: |
Mon, 22 Feb 2021 14:43:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/22/21 2:36 PM, Claudio Fontana wrote:
> the lack of target_user_arch makes it hard to fully leverage the
> build system in order to separate user code from softmmu code.
>
> Provide it, so that we can avoid the proliferation of #ifdef
> in target code.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
>
> [claudio: added changes for new target hexagon]
> ---
> meson.build | 5 +++++
> target/alpha/meson.build | 3 +++
> target/arm/meson.build | 2 ++
> target/cris/meson.build | 3 +++
> target/hexagon/meson.build | 3 +++
> target/hppa/meson.build | 3 +++
> target/i386/meson.build | 2 ++
> target/m68k/meson.build | 3 +++
> target/microblaze/meson.build | 3 +++
> target/mips/meson.build | 3 +++
> target/nios2/meson.build | 3 +++
> target/openrisc/meson.build | 3 +++
> target/ppc/meson.build | 3 +++
> target/riscv/meson.build | 3 +++
> target/s390x/meson.build | 3 +++
> target/sh4/meson.build | 3 +++
> target/sparc/meson.build | 3 +++
> target/tilegx/meson.build | 3 +++
> target/tricore/meson.build | 3 +++
> target/xtensa/meson.build | 3 +++
> 20 files changed, 60 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index 05a67c20d9..5be4e5f38c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1735,6 +1735,7 @@ modules = {}
> hw_arch = {}
> target_arch = {}
> target_softmmu_arch = {}
> +target_user_arch = {}
>
> ###############
> # Trace files #
> @@ -2132,6 +2133,10 @@ foreach target : target_dirs
> abi = config_target['TARGET_ABI_DIR']
> target_type='user'
> qemu_target_name = 'qemu-' + target_name
> + t = target_user_arch[arch].apply(config_target, strict: false)
> + arch_srcs += t.sources()
> + arch_deps += t.dependencies()
> +
> if 'CONFIG_LINUX_USER' in config_target
> base_dir = 'linux-user'
> target_inc += include_directories('linux-user/host/' /
> config_host['ARCH'])
I agree with Richard about a later
s/target_softmmu_arch/target_system_arch/ cleanup.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v21 00/17] i386 cleanup PART 2, Claudio Fontana, 2021/02/22
- [PATCH v21 02/17] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/22
- [PATCH v21 03/17] accel: introduce new accessor functions, Claudio Fontana, 2021/02/22
- [PATCH v21 06/17] meson: add target_user_arch, Claudio Fontana, 2021/02/22
- Re: [PATCH v21 06/17] meson: add target_user_arch,
Philippe Mathieu-Daudé <=
- [PATCH v21 07/17] i386: split off softmmu-only functionality in tcg-cpu, Claudio Fontana, 2021/02/22
- [PATCH v21 01/17] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/02/22
- [PATCH v21 08/17] i386: split smm helper (softmmu), Claudio Fontana, 2021/02/22
- [PATCH v21 09/17] i386: split tcg excp_helper into softmmu and user parts, Claudio Fontana, 2021/02/22
- [PATCH v21 04/17] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/22
- [PATCH v21 05/17] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/22
- [PATCH v21 14/17] i386: split seg_helper into user-only and softmmu parts, Claudio Fontana, 2021/02/22
- [PATCH v21 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU, Claudio Fontana, 2021/02/22
- [PATCH v21 10/17] i386: move TCG btp_helper into softmmu/, Claudio Fontana, 2021/02/22
- [PATCH v21 13/17] i386: split svm_helper into softmmu and stub-only user, Claudio Fontana, 2021/02/22