[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/8] hw/sh4: Add missing license
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 1/8] hw/sh4: Add missing license |
Date: |
Mon, 22 Feb 2021 13:55:48 +0000 |
On Sun, 21 Feb 2021 at 21:59, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> This code was introduced in commit 27c7ca7e775,
> ("SHIX board emulation (Samuel Tardieu)"). Use
> the same license.
>
> Cc: Samuel Tardieu <sam@rfc1149.net>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/sh4/sh.h | 12 +++++++++---
> hw/block/tc58128.c | 7 +++++++
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h
> index 93f464bf4cd..33dde7a56dd 100644
> --- a/include/hw/sh4/sh.h
> +++ b/include/hw/sh4/sh.h
> @@ -1,6 +1,12 @@
> -#ifndef QEMU_SH_H
> -#define QEMU_SH_H
> -/* Definitions for SH board emulation. */
> +/*
> + * Definitions for SH board emulation
> + *
> + * Copyright (c) 2005 Samuel Tardieu
> + *
> + * SPDX-License-Identifier: MIT
> + */
I thought it wasn't generally recommended to convert
a license text to a single SPDX line? The sh7750.c file
has a full 3-para license text.
thanks
-- PMM
- [PATCH v3 0/8] hw/sh4: Kconfig cleanups, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 3/8] hw/intc: Introduce SH_INTC Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 4/8] hw/char: Introduce SH_SCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 5/8] hw/timer: Introduce SH_TIMER Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 6/8] hw/block: Introduce TC58128 eeprom Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 7/8] hw/pci-host: Introduce SH_PCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 8/8] hw/sh4: Remove now unused CONFIG_SH4 from Kconfig, Philippe Mathieu-Daudé, 2021/02/21