[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers |
Date: |
Tue, 23 Feb 2021 19:55:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/23/21 9:24 AM, Mark Cave-Ayland wrote:
> On 16/02/2021 07:30, Philippe Mathieu-Daudé wrote:
>
>>> Are you planning to review any more of this series? I'm keen to put out
>>> a (hopefully final) v3 soon, but I'll hold off for little while if you
>>> want more time to look over the remaining patches.
>>
>> I talked about this series with Laurent on Sunday, asking him for
>> review help ;) I don't remember if there is any big comment to
>> address in patches 1-14. If not I can review the missing ones
>> there today and you could send directly a pull request for this
>> first set, then send the rest as v3. Does that help?
>> For the rest I doubt having time to focus before Friday.
>
> Hi Phil/Laurent,
>
> I know you're both really busy, but gentle ping to ask if anyone is
> still planning to review the second half of this patchset? :)
At this point I reviewed more than half of the series :)
Laurent, can you have a look at the upper half?
- [PATCH v2 26/42] esp: rename get_cmd_cb() to esp_select(), (continued)
- [PATCH v2 26/42] esp: rename get_cmd_cb() to esp_select(), Mark Cave-Ayland, 2021/02/09
- [PATCH v2 27/42] esp: fix PDMA target selection, Mark Cave-Ayland, 2021/02/09
- [PATCH v2 28/42] esp: use FIFO for PDMA transfers between initiator and device, Mark Cave-Ayland, 2021/02/09
- [PATCH v2 29/42] esp: remove pdma_origin from ESPState, Mark Cave-Ayland, 2021/02/09
- [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers, Mark Cave-Ayland, 2021/02/09
[PATCH v2 31/42] esp: implement FIFO flush command, Mark Cave-Ayland, 2021/02/09
[PATCH v2 32/42] esp: latch individual bits in ESP_RINTR register, Mark Cave-Ayland, 2021/02/09
[PATCH v2 34/42] esp: remove old deferred command completion mechanism, Mark Cave-Ayland, 2021/02/09
[PATCH v2 33/42] esp: defer command completion interrupt on incoming data transfers, Mark Cave-Ayland, 2021/02/09
[PATCH v2 35/42] esp: raise interrupt after every non-DMA byte transferred to the FIFO, Mark Cave-Ayland, 2021/02/09
[PATCH v2 37/42] esp: transition to message out phase after SATN and stop command, Mark Cave-Ayland, 2021/02/09
[PATCH v2 36/42] esp: add maxlen parameter to get_cmd(), Mark Cave-Ayland, 2021/02/09
[PATCH v2 38/42] esp: convert ti_buf from array to Fifo8, Mark Cave-Ayland, 2021/02/09