[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/6] qapi: Add support for aliases

From: Markus Armbruster
Subject: Re: [PATCH v2 0/6] qapi: Add support for aliases
Date: Wed, 24 Feb 2021 09:45:50 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Kevin Wolf <kwolf@redhat.com> writes:

> This series introduces alias definitions for QAPI object types (structs
> and unions).
> This allows using the same QAPI type and visitor even when the syntax
> has some variations between different external interfaces such as QMP
> and the command line.
> It also provides a new tool for evolving the schema while maintaining
> backwards compatibility (possibly during a deprecation period).
> The first user is intended to be a QAPIfied -chardev command line
> option, for which I'll send a separate series. A git tag is available
> that contains both this series and the chardev changes that make use of
> it:
>     https://repo.or.cz/qemu/kevin.git qapi-alias-chardev-v2

I'm done.  Summary:

PATCH 1: Update to the big comment is still missing, but we can do that
last.  I also flagged a possible contract clarification.

PATCH 2: Nits.

PATCH 3: Commit message questions.

PATCH 4: This one gave me trouble, and I feel unable to summarize.  I'm
afraid you have to wade through my review to answer questions and
address issues as far as practical.  And then we try again with v3.

PATCH 5: Documentation tweaks.

PATCH 6: Please consider adding more positive tests, as discussed in
review of PATCH 5.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]