[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 12/13] virtio-mem: Require only coordinated discards
From: |
David Hildenbrand |
Subject: |
[PATCH v7 12/13] virtio-mem: Require only coordinated discards |
Date: |
Wed, 24 Feb 2021 10:49:08 +0100 |
We implement the RamDiscardManager interface and only require coordinated
discarding of RAM to work.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Auger Eric <eric.auger@redhat.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: teawater <teawaterz@linux.alibaba.com>
Cc: Marek Kedzierski <mkedzier@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/virtio-mem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index cbd07fc9f1..9e79b5b50c 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -719,7 +719,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
return;
}
- if (ram_block_discard_require(true)) {
+ if (ram_block_coordinated_discard_require(true)) {
error_setg(errp, "Discarding RAM is disabled");
return;
}
@@ -727,7 +727,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
ret = ram_block_discard_range(rb, 0, qemu_ram_get_used_length(rb));
if (ret) {
error_setg_errno(errp, -ret, "Unexpected error discarding RAM");
- ram_block_discard_require(false);
+ ram_block_coordinated_discard_require(false);
return;
}
@@ -771,7 +771,7 @@ static void virtio_mem_device_unrealize(DeviceState *dev)
virtio_del_queue(vdev, 0);
virtio_cleanup(vdev);
g_free(vmem->bitmap);
- ram_block_discard_require(false);
+ ram_block_coordinated_discard_require(false);
}
static int virtio_mem_discard_range_cb(const VirtIOMEM *vmem, void *arg,
--
2.29.2
- [PATCH v7 02/13] memory: Helpers to copy/free a MemoryRegionSection, (continued)
- [PATCH v7 02/13] memory: Helpers to copy/free a MemoryRegionSection, David Hildenbrand, 2021/02/24
- [PATCH v7 03/13] virtio-mem: Factor out traversing unplugged ranges, David Hildenbrand, 2021/02/24
- [PATCH v7 04/13] virtio-mem: Don't report errors when ram_block_discard_range() fails, David Hildenbrand, 2021/02/24
- [PATCH v7 05/13] virtio-mem: Implement RamDiscardManager interface, David Hildenbrand, 2021/02/24
- [PATCH v7 06/13] vfio: Support for RamDiscardManager in the !vIOMMU case, David Hildenbrand, 2021/02/24
- [PATCH v7 07/13] vfio: Query and store the maximum number of possible DMA mappings, David Hildenbrand, 2021/02/24
- [PATCH v7 09/13] vfio: Support for RamDiscardManager in the vIOMMU case, David Hildenbrand, 2021/02/24
- [PATCH v7 10/13] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require), David Hildenbrand, 2021/02/24
- [PATCH v7 11/13] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types, David Hildenbrand, 2021/02/24
- [PATCH v7 08/13] vfio: Sanity check maximum number of DMA mappings with RamDiscardManager, David Hildenbrand, 2021/02/24
- [PATCH v7 12/13] virtio-mem: Require only coordinated discards,
David Hildenbrand <=
- [PATCH v7 13/13] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus, David Hildenbrand, 2021/02/24