[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ui/cocoa: Fix mouse association state

From: Gerd Hoffmann
Subject: Re: [PATCH v2] ui/cocoa: Fix mouse association state
Date: Wed, 24 Feb 2021 12:27:52 +0100

On Tue, Feb 23, 2021 at 12:07:14AM +0900, Akihiko Odaki wrote:
> ui/cocoa deassociates the mouse input and the mouse cursor
> position only when relative movement inputs are expected. Such
> inputs may let the mouse cursor leave the view and cause undesired
> side effects if they are associated. On the other hand, the
> problem does not occur when inputting absolute points, and the
> association allows seamless cursor movement across views.
> However, the synchronization of the association and the expected
> input type was only done when grabbing the mouse. In reality, the
> state whether the emulated input device expects absolute pointing
> inputs or relative movement inputs can vary dynamically due to
> USB device hot-plugging, for example.
> This change adds association state updates according to input type
> expectation changes. It also removes an internal flag representing
> the association state because the state can now be determined with
> the current input type expectation and it only adds the
> complexity of the state tracking.

Patch looks reasonable to me, but I'd like to see an review from
someone who knows macos better than I do for this one.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]