[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: Fix parse errors for removal of null from schema langu
Re: [PATCH] qapi: Fix parse errors for removal of null from schema language
Wed, 24 Feb 2021 07:34:09 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0
On 2/24/21 4:14 AM, Markus Armbruster wrote:
> Commit 9d55380b5a "qapi: Remove null from schema language" (v4.2.0)
> neglected to update two error messages. Do that now.
> Signed-off-by: Markus Armbruster <firstname.lastname@example.org>
> scripts/qapi/parser.py | 8 ++++----
> tests/qapi-schema/leading-comma-list.err | 2 +-
> tests/qapi-schema/trailing-comma-list.err | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
My first reaction was "How does our 'StrOrNull' alternate type work?
But I see that uses 'null' (that is, a string type name, just like 'str'
or 'int'), and not a literal null. At which point this makes total sense.
Reviewed-by: Eric Blake <email@example.com>
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org