[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] softmmu: remove '-usbdevice' command line option
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 04/14] softmmu: remove '-usbdevice' command line option |
Date: |
Wed, 24 Feb 2021 14:10:57 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Wed, Feb 24, 2021 at 02:58:19PM +0100, Thomas Huth wrote:
> On 24/02/2021 14.11, Daniel P. Berrangé wrote:
> > This was replaced by the '-device usb-DEV' option.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > docs/system/deprecated.rst | 9 -------
> > docs/system/removed-features.rst | 9 +++++++
> > softmmu/vl.c | 42 --------------------------------
> > 3 files changed, 9 insertions(+), 51 deletions(-)
>
> Last time I tried to remove -usbdevice, there was some concerns that
> -usbdevice braille might still be useful for some people, see the thread
> that started here:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00651.html
>
> (and Gerd's summary here:
> https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg01520.html )
Urgh, so the current deprecation docs are a bit misleading by saying
-usbdevice is directly mapped to -device.
> So we might need a new "sugared" option like "-braille" instead before we
> can fully remove -usbdevice? ... or we just keep -usbdevice as a bittersweet
> remainder?
I'm not going to implement new CLI options, and if that's needed, we
ought to re-start the clock on the deprecation at that point. So this
points towards just removing the deprecation warning that exists
today. Or alternatively drop support for -usbdevice, except for the
braille type.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP commands, (continued)
- [PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime and cache size, Daniel P . Berrangé, 2021/02/24
- [PATCH 07/14] machine: remove 'arch' field from 'query-cpus-fast' QMP command, Daniel P . Berrangé, 2021/02/24
- [PATCH 08/14] chardev: reject use of 'wait' flag for socket client chardevs, Daniel P . Berrangé, 2021/02/24
- [PATCH 06/14] machine: remove 'query-cpus' QMP command, Daniel P . Berrangé, 2021/02/24
- [PATCH 09/14] hw/ide: remove 'ide-drive' device, Daniel P . Berrangé, 2021/02/24
- [PATCH 10/14] hw/scsi: remove 'scsi-disk' device, Daniel P . Berrangé, 2021/02/24