[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd |
Date: |
Wed, 24 Feb 2021 15:31:12 +0000 |
On Wed, Feb 24, 2021 at 02:22:31PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Feb 22, 2021 at 8:11 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> > For some reason memfd never used share=on. vhost-user relies on
> > mmap(MAP_SHARED) so this seems like a problem, but the tests still run
> > without it.
> >
> >
> Simply because it's on by default with memory-backend-memfd (it wouldn't
> make much sense to use memfd in the first place without share)
Thanks for solving this mystery!
Please update the commit description with this information when merging
(or I'll update it when respinning).
Stefan
signature.asc
Description: PGP signature