[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/31] qapi/qom: QAPIfy --object and object-add

From: Peter Krempa
Subject: Re: [PATCH v2 00/31] qapi/qom: QAPIfy --object and object-add
Date: Wed, 24 Feb 2021 17:01:43 +0100
User-agent: Mutt/1.14.6 (2020-07-11)

On Wed, Feb 24, 2021 at 14:52:24 +0100, Kevin Wolf wrote:
> This series adds a QAPI type for the properties of all user creatable
> QOM types and finally makes the --object command line option (in all
> binaries) and the object-add monitor commands (in QMP and HMP) use the
> new ObjectOptions union.
> This change improves things in more than just one way:
> 1. Documentation for QOM object types has always been lacking. Adding
>    the schema, we get documentation for every property.
> 2. It prevents bugs by performing parts of the input validation (e.g.
>    checking presence of mandatory properties) already in QAPI instead of
>    relying on separate manual implementations in each class.
> 3. It provides QAPI introspection for user creatable objects.
> 4. Non-scalar properties are now supported everywhere because the
>    command line parsers (including HMP) use the keyval parser now.

I've updated and posted another version of the libvirt patches which add
testing that our generated props conform to the schema and also deals
with the dropped 'props' wrapper:


Libvirt's test pass after it without any change, so on behalf of libvirt

ACKed-by: Peter Krempa <pkrempa@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]