Re: [PATCH 2/2] gitlab-ci.yml: Add jobs to test CFI flags

[Paolo Bonzini]

On 24/02/21 18:55, Daniele Buono wrote:
> > Does it make sense to test only one target instead?
>
> I'd prefer grouping multiple targets per job so that the number of jobs doesn't 
> explode, and stopping ninja from linking in parallel does solve the issue.

Yeah, backend_max_links should do it.  The 3 hour timeout scared me.

> > Can you explain what you mean, and perhaps add a check or warning for 
> > incompatible settings?
>
> Certainly. The issue here is that there is a function in libslirp that
> is used as callbacks for QEMU Timers: ra_timer_handler
> (There may be others, but of this one I'm sure because I traced it).
>
> This is not an issue when you compile slirp with qemu, since the whole
> library now has CFI informations and is statically linked in the QEMU
> binary. It becomes an issue if you are dynamically linking a system-wide
> libslirp, as it happens on Fedora.
>
> I'd be happy to add a check on configure/meson that ends the configure
> step with an error when this happens, but that would technically be an
> independent patch that I'd work on in parallel to this one.
> I would prefer to not automatically select the git-based libslirp
> because that may go unnoticed when configuring.

Sounds good.  For now just add a comment, please.

Paolo