[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL |
Date: |
Wed, 24 Feb 2021 19:57:01 +0100 |
We already have a macro and definition to extract / check
the Special2 MUL opcode. Use it instead of the unnecessary
OPC__MXU_MUL macro.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 9e875fa4a25..2d8ddbad112 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -1464,7 +1464,6 @@ enum {
*/
enum {
- OPC__MXU_MUL = 0x02,
OPC_MXU__POOL00 = 0x03,
OPC_MXU_D16MUL = 0x08,
OPC_MXU_D16MAC = 0x0A,
@@ -25784,7 +25783,7 @@ static void decode_opc_mxu(DisasContext *ctx, uint32_t
insn)
{
uint32_t opcode = extract32(insn, 0, 6);
- if (opcode == OPC__MXU_MUL) {
+ if (MASK_SPECIAL2(insn) == OPC_MUL) {
uint32_t rs, rt, rd, op1;
rs = extract32(insn, 21, 5);
--
2.26.2
- [PATCH v4 00/12] target/mips: Extract MXU code to new mxu_translate.c file, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu(), Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL,
Philippe Mathieu-Daudé <=
- [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy(), Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file, Philippe Mathieu-Daudé, 2021/02/24