[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree pro
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype |
|
Date: |
Wed, 24 Feb 2021 19:57:03 +0100 |
To easily convert MXU code to decodetree, making it return a boolean.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/translate.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index df4868ebb95..f25b1fe4d8f 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -25779,18 +25779,18 @@ static void decode_opc_mxu__pool19(DisasContext *ctx)
/*
* Main MXU decoding function
*/
-static void decode_opc_mxu(DisasContext *ctx, uint32_t insn)
+static bool decode_ase_mxu(DisasContext *ctx, uint32_t insn)
{
uint32_t opcode = extract32(insn, 0, 6);
if (opcode == OPC_MXU_S32M2I) {
gen_mxu_s32m2i(ctx);
- return;
+ return true;
}
if (opcode == OPC_MXU_S32I2M) {
gen_mxu_s32i2m(ctx);
- return;
+ return true;
}
{
@@ -25831,6 +25831,8 @@ static void decode_opc_mxu(DisasContext *ctx, uint32_t
insn)
gen_set_label(l_exit);
tcg_temp_free(t_mxu_cr);
}
+
+ return true;
}
#endif /* !defined(TARGET_MIPS64) */
@@ -26984,7 +26986,7 @@ static bool decode_opc_legacy(CPUMIPSState *env,
DisasContext *ctx)
if (MASK_SPECIAL2(ctx->opcode) == OPC_MUL) {
gen_arith(ctx, OPC_MUL, rd, rs, rt);
} else {
- decode_opc_mxu(ctx, ctx->opcode);
+ decode_ase_mxu(ctx, ctx->opcode);
}
break;
}
--
2.26.2
- Re: [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set, (continued)
- [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu(), Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy(), Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype,
Philippe Mathieu-Daudé <=
- [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file, Philippe Mathieu-Daudé, 2021/02/24