[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu(
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy() |
Date: |
Wed, 24 Feb 2021 11:06:11 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/24/21 10:57 AM, Philippe Mathieu-Daudé wrote:
> Move the check for MUL opcode from decode_opc_mxu() callee
> to decode_opc_legacy() caller, so we can simplify the ifdef'ry
> and elide the call in few commits.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set, (continued)
- [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu(), Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy(), Philippe Mathieu-Daudé, 2021/02/24
- Re: [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy(),
Richard Henderson <=
- [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper, Philippe Mathieu-Daudé, 2021/02/24
- [PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file, Philippe Mathieu-Daudé, 2021/02/24