Re: [PATCH v22 08/17] i386: split smm helper (sysemu)

[Richard Henderson]

On 2/24/21 5:34 AM, Claudio Fontana wrote:
> smm is only really useful for sysemu, split in two modules
> around the CONFIG_USER_ONLY, in order to remove the ifdef
> and use the build system instead.
> 
> add cpu_abort() when detecting attempts to enter SMM mode via
> SMI interrupt in user-mode, and assert that the cpu is not
> in SMM mode while translating RSM instructions.
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  target/i386/helper.h                      |  4 ++++
>  target/i386/tcg/seg_helper.c              |  4 ++++
>  target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++-----------------
>  target/i386/tcg/translate.c               |  5 +++++
>  target/i386/tcg/meson.build               |  1 -
>  target/i386/tcg/sysemu/meson.build        |  1 +
>  6 files changed, 16 insertions(+), 18 deletions(-)
>  rename target/i386/tcg/{ => sysemu}/smm_helper.c (98%)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~