[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/
From: |
Richard Henderson |
Subject: |
Re: [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/ |
Date: |
Wed, 24 Feb 2021 17:40:43 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/24/21 5:34 AM, Claudio Fontana wrote:
> @@ -8074,7 +8078,9 @@ static target_ulong disas_insn(DisasContext *s,
> CPUState *cpu)
> gen_svm_check_intercept(s, pc_start, SVM_EXIT_WRITE_DR0 +
> reg);
> gen_op_mov_v_reg(s, ot, s->T0, rm);
> tcg_gen_movi_i32(s->tmp2_i32, reg);
> +#ifndef CONFIG_USER_ONLY
> gen_helper_set_dr(cpu_env, s->tmp2_i32, s->T0);
> +#endif /* CONFIG_USER_ONLY */
> gen_jmp_im(s, s->pc - s->cs_base);
> gen_eob(s);
Given that you need the ifdef, you might as well extend it to the entire else
of s->cpl != 0. User-only will always have cpl == 3.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v22 05/17] accel-cpu: make cpu_realizefn return a bool, (continued)
- [PATCH v22 09/17] i386: split tcg excp_helper into sysemu and user parts, Claudio Fontana, 2021/02/24
- [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/, Claudio Fontana, 2021/02/24
- Re: [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/,
Richard Henderson <=
- [PATCH v22 13/17] i386: split svm_helper into sysemu and stub-only user, Claudio Fontana, 2021/02/24
- [PATCH v22 12/17] i386: separate fpu_helper into user and sysemu parts, Claudio Fontana, 2021/02/24
- [PATCH v22 14/17] i386: split seg_helper into user-only and sysemu parts, Claudio Fontana, 2021/02/24
- [PATCH v22 11/17] i386: split misc helper into user and sysemu parts, Claudio Fontana, 2021/02/24
- [PATCH v22 17/17] i386: move cpu_load_efer into sysemu-only section of cpu.h, Claudio Fontana, 2021/02/24