[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console |
Date: |
Thu, 25 Feb 2021 10:10:49 +0100 |
> - if (m->scanout_id == 0 && m->width == 0) {
> + if (m->width == 0) {
> s->ds = qemu_create_placeholder_surface(640, 480,
> "Guest disabled
> display.");
> dpy_gfx_replace_surface(con, s->ds);
Just call dpy_gfx_replace_surface(con, NULL) here and let console.c
create the placeholder?
> for (i = 0; i < g->conf.max_outputs; i++) {
> g->scanout[i].con =
> graphic_console_init(DEVICE(g), i, &virtio_gpu_ops, g);
> - if (i > 0) {
> - dpy_gfx_replace_surface(g->scanout[i].con, NULL);
> - }
I think we should call dpy_gfx_replace_surface(..., NULL)
unconditionally here instead of removing the call.
> + /* primary head */
Comment can go away as we remove the special case for scanout == 0,
> + ds = qemu_create_placeholder_surface(scanout->width ?: 640,
> + scanout->height ?: 480,
> + "Guest disabled display.");
> dpy_gfx_replace_surface(scanout->con, ds);
likewise "dpy_gfx_replace_surface(..., NULL);"
take care,
Gerd
- [PATCH] ui/console: Assert graphic console surface is not NULL, Akihiko Odaki, 2021/02/19
- Re: [PATCH] ui/console: Assert graphic console surface is not NULL, Gerd Hoffmann, 2021/02/19
- [PATCH v2] ui/console: Pass placeholder surface to displays, Akihiko Odaki, 2021/02/20
- Re: [PATCH v2] ui/console: Pass placeholder surface to displays, Gerd Hoffmann, 2021/02/22
- Re: [PATCH v2] ui/console: Pass placeholder surface to displays, Akihiko Odaki, 2021/02/22
- Re: [PATCH v2] ui/console: Pass placeholder surface to displays, Gerd Hoffmann, 2021/02/24
- [PATCH v3 1/3] ui/console: Add placeholder flag to message surface, Akihiko Odaki, 2021/02/24
- [PATCH v3 2/3] ui/console: Pass placeholder surface to displays, Akihiko Odaki, 2021/02/24
- Re: [PATCH v3 2/3] ui/console: Pass placeholder surface to displays, Gerd Hoffmann, 2021/02/25
- [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console, Akihiko Odaki, 2021/02/24
- Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console,
Gerd Hoffmann <=
- Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console, Akihiko Odaki, 2021/02/25
- Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console, Gerd Hoffmann, 2021/02/25
- Re: [PATCH v3 1/3] ui/console: Add placeholder flag to message surface, Gerd Hoffmann, 2021/02/25