[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] char: don't fail when client is not connected

From: Paolo Bonzini
Subject: Re: [PATCH v2] char: don't fail when client is not connected
Date: Thu, 25 Feb 2021 11:10:10 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 09/02/21 06:49, Pavel Dovgalyuk wrote:
This patch checks that ioc is not null before
using it in tcp socket tcp_chr_add_watch function.

The failure occurs in replay mode of the execution,
when monitor and serial port are tcp servers,
and there are no clients connected to them:

-monitor tcp:,server,nowait
-serial tcp:,server,nowait

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
  chardev/char-socket.c |    3 +++
  1 file changed, 3 insertions(+)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 213a4c8dd0..cef1d9438f 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -385,6 +385,9 @@ static ssize_t tcp_chr_recv(Chardev *chr, char *buf, size_t 
  static GSource *tcp_chr_add_watch(Chardev *chr, GIOCondition cond)
      SocketChardev *s = SOCKET_CHARDEV(chr);
+    if (!s->ioc) {
+        return NULL;
+    }
      return qio_channel_create_watch(s->ioc, cond);

Queued, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]