Re: [PATCH] tcg/i386: rdpmc: use the the condtions

[Paolo Bonzini]

On 25/02/21 11:13, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
>
> On 2/25/21 11:07 AM, Paolo Bonzini wrote:
> > On 25/02/21 06:47, Zheng Zhan Liang wrote:
> > > Signed-off-by: Zheng Zhan Liang <linuxmaker@163.com>
> > > ---
> > >    target/i386/tcg/misc_helper.c | 3 ++-
> > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/target/i386/tcg/misc_helper.c
> > > b/target/i386/tcg/misc_helper.c
> > > index f02e4fd400..90b87fdef0 100644
> > > --- a/target/i386/tcg/misc_helper.c
> > > +++ b/target/i386/tcg/misc_helper.c
> > > @@ -222,7 +222,8 @@ void helper_rdtscp(CPUX86State *env)
> > >      void helper_rdpmc(CPUX86State *env)
> > >    {
> > > -    if ((env->cr[4] & CR4_PCE_MASK) && ((env->hflags & HF_CPL_MASK)
> > > != 0)) {
> > > +    if (((env->cr[4] & CR4_PCE_MASK) == 0 ) &&
> > > +        ((env->hflags & HF_CPL_MASK) != 0)) {
> > >            raise_exception_ra(env, EXCP0D_GPF, GETPC());
> > >        }
> > >        cpu_svm_check_intercept_param(env, SVM_EXIT_RDPMC, 0, GETPC());
> >
> > Queued, thanks.
>
> Do you mind fixing the patch subject?

Yes, done already actually.  Thanks,

Paolo