[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/42] esp: consolidate PDMA transfer buffers and other fi

From: Mark Cave-Ayland
Subject: Re: [PATCH v2 00/42] esp: consolidate PDMA transfer buffers and other fixes
Date: Thu, 25 Feb 2021 19:17:19 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 25/02/2021 10:50, Philippe Mathieu-Daudé wrote:

Thanks Phil - I understand that a set of 42 patches for a 25 year old
disk controller is never going to be the top of most people's review
list, and some parts are almost impossible to review unless you have a
good understanding of the datasheet.

Well I also have a series for a 30+ years old MIPS board and am
not confident to post it because probably little interest for
the community, although it is very interesting to compare with
actual SoC and see how the IP blocks are indeed reused and improved
over the time -- or not... i.e. when someone report a hw bug in a 2020
product and the same bug is present in the IP core from the 80th it
inherited ;)

I'll see if Laurent has any comments over the next few days, but other
than that I'd be inclined to send a v3 followed soon by a PR to avoid me
having to update these regularly (I already see a slight conflict with
Paolo's SCSI error handling changes, for example).

I'll have a look at your v3 and Cc you when I post this MIPS board :D

Well I can do a cursory review of the patches, but I can't really say I've got much in the way of MIPS experience to be able to review in depth. If you feel that you would like some R-B tags before sending a PR then I can certainly give it another set of eyeballs.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]