Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases

From:	John Snow
Subject:	Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases
Date:	Thu, 25 Feb 2021 17:10:32 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/25/21 7:07 AM, Markus Armbruster wrote:

Unfortunately, the "check" in check_exprs falls off almost immediately.

What do you mean by "falls off"?

mypy loses the constraint in its static analysis. i.e. all of the workwe do in expr.py is almost entirely opaque to mypy.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types, (continued)
- [PATCH v3 05/16] qapi/expr.py: move string check upwards in check_type, John Snow, 2021/02/22
- [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member, John Snow, 2021/02/22
  - Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member, Markus Armbruster, 2021/02/24
    - Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member, John Snow, 2021/02/24
    - Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member, Markus Armbruster, 2021/02/25
- [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/02/22
  - Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, Markus Armbruster, 2021/02/24
    - Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/02/24
    - Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, Markus Armbruster, 2021/02/25
    - Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, John Snow <=
- [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/02/22
  - Re: [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if, Markus Armbruster, 2021/02/25
    - Re: [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/02/25
- [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable, John Snow, 2021/02/22
  - Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable, Markus Armbruster, 2021/02/25
    - Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable, John Snow, 2021/02/25
- [PATCH v3 11/16] qapi/expr.py: enable pylint checks, John Snow, 2021/02/22
- [PATCH v3 12/16] qapi/expr.py: Add docstrings, John Snow, 2021/02/22
- [PATCH v3 08/16] qapi/expr.py: add type hint annotations, John Snow, 2021/02/22
  - Re: [PATCH v3 08/16] qapi/expr.py: add type hint annotations, Markus Armbruster, 2021/02/24

Prev by Date: Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable
Next by Date: Re: [PATCH v2 07/10] target/hexagon: import lexer for idef-parser
Previous by thread: Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases
Next by thread: [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if
Index(es):
- Date
- Thread