Re: [PULL 00/29] Misc patches for 2021-02-25

[no-reply]

Patchew URL: 
20210226080526.651705-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210226080526.651705-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210226080526.651705-1-pbonzini@redhat.com
Subject: [PULL 00/29] Misc patches for 2021-02-25

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210224104707.88430-1-vsementsov@virtuozzo.com -> 
patchew/20210224104707.88430-1-vsementsov@virtuozzo.com
 - [tag update]      patchew/20210225230238.3719051-1-philmd@redhat.com -> 
patchew/20210225230238.3719051-1-philmd@redhat.com
 * [new tag]         patchew/20210226080526.651705-1-pbonzini@redhat.com -> 
patchew/20210226080526.651705-1-pbonzini@redhat.com
Switched to a new branch 'test'
fd845d2 tcg/i386: rdpmc: fix the the condtions
6cca88e chardev: do not use short form boolean options in non-QemuOpts 
character device descriptions
c2d0b1e vl: deprecate -writeconfig
c6f0672 target/i386: Add bus lock debug exception support
6b7da9a qom/object.c: Fix typo
b047080 target/i386: update to show preferred boolean syntax for -cpu
28b0198 docs: update to show preferred boolean syntax for -cpu
9f60b11 docs: update to show preferred boolean syntax for -vnc
e30703a docs: update to show preferred boolean syntax for -chardev
2206acf qemu-options: update to show preferred boolean syntax for -vnc
7b7eee8 qemu-options: update to show preferred boolean syntax for -incoming
b37488e qemu-options: update to show preferred boolean syntax for -netdev
1b9e964 qemu-options: update to show preferred boolean syntax for -spice
2e5713d qemu-options: update to show preferred boolean syntax for -chardev
08175f4 gdbstub: use preferred boolean option syntax
8351a83 char: don't fail when client is not connected
a8f06f3 scsi: drop 'result' argument from command_complete callback
35e1184 scsi-disk: pass guest recoverable errors through even for rerror=stop
2b29728 scsi-disk: pass SCSI status to scsi_handle_rw_error
e675011 scsi: introduce scsi_sense_from_errno()
47e724a scsi-disk: do not complete requests early for rerror/werror=ignore
7b99c1e scsi-disk: move scsi_handle_rw_error earlier
4e79a75 virtio-scsi: don't process IO on fenced dataplane
3562b18 scsi: allow user to set werror as report
6b78981 scsi: add tracing for SG_IO commands
2852a13 scsi: make io_timeout configurable
d59ba35 multiprocess: move feature to meson_options.txt
12cf51e configure: fix --enable-fuzzing linker failures
fab94e9 hvf: Sign the code after installation

=== OUTPUT BEGIN ===
1/29 Checking commit fab94e9db883 (hvf: Sign the code after installation)
2/29 Checking commit 12cf51e986e9 (configure: fix --enable-fuzzing linker 
failures)
3/29 Checking commit d59ba353744e (multiprocess: move feature to 
meson_options.txt)
4/29 Checking commit 2852a13fda3c (scsi: make io_timeout configurable)
5/29 Checking commit 6b78981b63fb (scsi: add tracing for SG_IO commands)
6/29 Checking commit 3562b1842165 (scsi: allow user to set werror as report)
7/29 Checking commit 4e79a75c1ba4 (virtio-scsi: don't process IO on fenced 
dataplane)
8/29 Checking commit 7b99c1ea8a0e (scsi-disk: move scsi_handle_rw_error earlier)
WARNING: Block comments use a leading /* on a separate line
#53: FILE: hw/scsi/scsi-disk.c:204:
+            /* A passthrough command has run and has produced sense data; check

WARNING: line over 80 characters
#58: FILE: hw/scsi/scsi-disk.c:209:
+            if (scsi_sense_buf_is_guest_recoverable(r->req.sense, 
sizeof(r->req.sense))) {

WARNING: Block comments use a leading /* on a separate line
#67: FILE: hw/scsi/scsi-disk.c:218:
+            /* These errno mapping are specific to Linux.  For more 
information:

total: 0 errors, 3 warnings, 186 lines checked

Patch 8/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/29 Checking commit 47e724ab13a3 (scsi-disk: do not complete requests early 
for rerror/werror=ignore)
10/29 Checking commit e6750118d606 (scsi: introduce scsi_sense_from_errno())
WARNING: Block comments use a leading /* on a separate line
#116: FILE: scsi/utils.c:576:
+        /* These errno mapping are specific to Linux.  For more information:

total: 0 errors, 1 warnings, 130 lines checked

Patch 10/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/29 Checking commit 2b2972801829 (scsi-disk: pass SCSI status to 
scsi_handle_rw_error)
12/29 Checking commit 35e118474be4 (scsi-disk: pass guest recoverable errors 
through even for rerror=stop)
WARNING: line over 80 characters
#36: FILE: hw/scsi/scsi-disk.c:222:
+        scsi_sense_buf_is_guest_recoverable(r->req.sense, 
sizeof(r->req.sense))) {

total: 0 errors, 1 warnings, 67 lines checked

Patch 12/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/29 Checking commit a8f06f393647 (scsi: drop 'result' argument from 
command_complete callback)
14/29 Checking commit 8351a83ca714 (char: don't fail when client is not 
connected)
15/29 Checking commit 08175f4c58a0 (gdbstub: use preferred boolean option 
syntax)
16/29 Checking commit 2e5713d9eeac (qemu-options: update to show preferred 
boolean syntax for -chardev)
17/29 Checking commit 1b9e96482163 (qemu-options: update to show preferred 
boolean syntax for -spice)
18/29 Checking commit b37488efe677 (qemu-options: update to show preferred 
boolean syntax for -netdev)
19/29 Checking commit 7b7eee8a1d72 (qemu-options: update to show preferred 
boolean syntax for -incoming)
20/29 Checking commit 2206acf6a11e (qemu-options: update to show preferred 
boolean syntax for -vnc)
21/29 Checking commit e30703a0788d (docs: update to show preferred boolean 
syntax for -chardev)
22/29 Checking commit 9f60b1136ad1 (docs: update to show preferred boolean 
syntax for -vnc)
23/29 Checking commit 28b01988c540 (docs: update to show preferred boolean 
syntax for -cpu)
24/29 Checking commit b047080a0ea4 (target/i386: update to show preferred 
boolean syntax for -cpu)
25/29 Checking commit 6b7da9a79357 (qom/object.c: Fix typo)
26/29 Checking commit c6f0672a2a0b (target/i386: Add bus lock debug exception 
support)
27/29 Checking commit c2d0b1e59151 (vl: deprecate -writeconfig)
ERROR: line over 90 characters
#66: FILE: softmmu/vl.c:3359:
+                    warn_report("-writeconfig is deprecated.  It will go away 
in QEMU 6.2 with no replacement");

total: 1 errors, 0 warnings, 34 lines checked

Patch 27/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

28/29 Checking commit 6cca88eea4e4 (chardev: do not use short form boolean 
options in non-QemuOpts character device descriptions)
29/29 Checking commit fd845d25a429 (tcg/i386: rdpmc: fix the the condtions)
ERROR: space prohibited before that close parenthesis ')'
#24: FILE: target/i386/tcg/misc_helper.c:225:
+    if (((env->cr[4] & CR4_PCE_MASK) == 0 ) &&

total: 1 errors, 0 warnings, 9 lines checked

Patch 29/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210226080526.651705-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210226080526.651705-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com