[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v22 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOF
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v22 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU |
|
Date: |
Fri, 26 Feb 2021 07:07:46 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/26/21 1:22 AM, Claudio Fontana wrote:
>> I should think so, except... that FORCE_64 makes the previous test useless.
>> I
>> have no idea what's going on here.
>
> #ifdef TARGET_X86_64
> #define GDB_FORCE_64 1
> #else
> #define GDB_FORCE_64 0
> #endif
>
> So for TARGET_X86_64, GDB_FORCE_64 is always 1.
>
> Maybe the flags is there for when a cpu switches between modes? (32vs64 bit)?
But of course the only cpu that could switch is TARGET_X86_64.
So... as I said, I have no idea what's going on.
> I'll make a conservative patch that does not risk changing the behavior (at
> least in the intention).
Sure.
r~
- [PATCH v22 11/17] i386: split misc helper into user and sysemu parts, (continued)
[PATCH v22 15/17] i386: split off sysemu part of cpu.c, Claudio Fontana, 2021/02/24
Re: [PATCH v22 00/17] i386 cleanup PART 2, no-reply, 2021/02/24
Re: [PATCH v22 00/17] i386 cleanup PART 2, Philippe Mathieu-Daudé, 2021/02/24