[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v24 12/18] i386: separate fpu_helper into user and sysemu par
From: |
Richard Henderson |
Subject: |
Re: [PATCH v24 12/18] i386: separate fpu_helper into user and sysemu parts |
Date: |
Fri, 26 Feb 2021 07:54:30 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/26/21 1:49 AM, Claudio Fontana wrote:
> +/*
> + * XXX in helper_fsave() we reference GETPC(). Which is only valid when
> + * directly called from code_gen_buffer.
> + *
> + * The signature of cpu_x86_foo should be changed to add a "uintptr_t
> retaddr"
> + * argument, the callers from linux-user/i386/signal.c must pass 0 for this
> + * new argument (no unwind required), and the helpers must do
> + *
> + * void helper_fsave(CPUX86State *env, target_ulong ptr, int data32)
> + * {
> + * cpu_x86_fsave(env, ptr, data32, GETPC());
> + * }
> + *
> + * etc.
> + */
I'll send a patch to fix this rather than document it.
It will mean that you can't split out these little helpers to a new file, at
least not reasonably.
r~
- [PATCH v24 03/18] accel: introduce new accessor functions, (continued)
- [PATCH v24 03/18] accel: introduce new accessor functions, Claudio Fontana, 2021/02/26
- [PATCH v24 06/18] meson: add target_user_arch, Claudio Fontana, 2021/02/26
- [PATCH v24 05/18] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/26
- [PATCH v24 02/18] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/26
- [PATCH v24 08/18] i386: split smm helper (sysemu), Claudio Fontana, 2021/02/26
- [PATCH v24 07/18] i386: split off sysemu-only functionality in tcg-cpu, Claudio Fontana, 2021/02/26
- [PATCH v24 10/18] i386: move TCG btp_helper into sysemu/, Claudio Fontana, 2021/02/26
- [PATCH v24 12/18] i386: separate fpu_helper into user and sysemu parts, Claudio Fontana, 2021/02/26
- Re: [PATCH v24 12/18] i386: separate fpu_helper into user and sysemu parts,
Richard Henderson <=
- [PATCH v24 09/18] i386: split tcg excp_helper into sysemu and user parts, Claudio Fontana, 2021/02/26
- [PATCH v24 13/18] i386: split svm_helper into sysemu and stub-only user, Claudio Fontana, 2021/02/26
- [PATCH v24 14/18] i386: split seg_helper into user-only and sysemu parts, Claudio Fontana, 2021/02/26
- [PATCH v24 16/18] target/i386: gdbstub: introduce aux functions to read/write CS64 regs, Claudio Fontana, 2021/02/26
- [PATCH v24 17/18] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu, Claudio Fontana, 2021/02/26
- [PATCH v24 11/18] i386: split misc helper user stubs and sysemu part, Claudio Fontana, 2021/02/26