[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v25 01/20] target/i386: Rename helper_fldt, helper_fstt
From: |
Claudio Fontana |
Subject: |
[PATCH v25 01/20] target/i386: Rename helper_fldt, helper_fstt |
Date: |
Fri, 26 Feb 2021 18:51:24 +0100 |
From: Richard Henderson <richard.henderson@linaro.org>
Change the prefix from "helper" to "do". The former should be
reserved for those functions that are called from TCG; the latter
is in use within the file already for those functions that are
called from the helper functions, adding a "retaddr" argument.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Tested-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/i386/tcg/fpu_helper.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c
index 60ed93520a..3d9b192901 100644
--- a/target/i386/tcg/fpu_helper.c
+++ b/target/i386/tcg/fpu_helper.c
@@ -117,8 +117,7 @@ static inline void fpop(CPUX86State *env)
env->fpstt = (env->fpstt + 1) & 7;
}
-static inline floatx80 helper_fldt(CPUX86State *env, target_ulong ptr,
- uintptr_t retaddr)
+static floatx80 do_fldt(CPUX86State *env, target_ulong ptr, uintptr_t retaddr)
{
CPU_LDoubleU temp;
@@ -127,8 +126,8 @@ static inline floatx80 helper_fldt(CPUX86State *env,
target_ulong ptr,
return temp.d;
}
-static inline void helper_fstt(CPUX86State *env, floatx80 f, target_ulong ptr,
- uintptr_t retaddr)
+static void do_fstt(CPUX86State *env, floatx80 f, target_ulong ptr,
+ uintptr_t retaddr)
{
CPU_LDoubleU temp;
@@ -405,14 +404,14 @@ void helper_fldt_ST0(CPUX86State *env, target_ulong ptr)
int new_fpstt;
new_fpstt = (env->fpstt - 1) & 7;
- env->fpregs[new_fpstt].d = helper_fldt(env, ptr, GETPC());
+ env->fpregs[new_fpstt].d = do_fldt(env, ptr, GETPC());
env->fpstt = new_fpstt;
env->fptags[new_fpstt] = 0; /* validate stack entry */
}
void helper_fstt_ST0(CPUX86State *env, target_ulong ptr)
{
- helper_fstt(env, ST0, ptr, GETPC());
+ do_fstt(env, ST0, ptr, GETPC());
}
void helper_fpush(CPUX86State *env)
@@ -2468,7 +2467,7 @@ void helper_fsave(CPUX86State *env, target_ulong ptr, int
data32)
ptr += (14 << data32);
for (i = 0; i < 8; i++) {
tmp = ST(i);
- helper_fstt(env, tmp, ptr, GETPC());
+ do_fstt(env, tmp, ptr, GETPC());
ptr += 10;
}
@@ -2495,7 +2494,7 @@ void helper_frstor(CPUX86State *env, target_ulong ptr,
int data32)
ptr += (14 << data32);
for (i = 0; i < 8; i++) {
- tmp = helper_fldt(env, ptr, GETPC());
+ tmp = do_fldt(env, ptr, GETPC());
ST(i) = tmp;
ptr += 10;
}
@@ -2539,7 +2538,7 @@ static void do_xsave_fpu(CPUX86State *env, target_ulong
ptr, uintptr_t ra)
addr = ptr + XO(legacy.fpregs);
for (i = 0; i < 8; i++) {
floatx80 tmp = ST(i);
- helper_fstt(env, tmp, addr, ra);
+ do_fstt(env, tmp, addr, ra);
addr += 16;
}
}
@@ -2703,7 +2702,7 @@ static void do_xrstor_fpu(CPUX86State *env, target_ulong
ptr, uintptr_t ra)
addr = ptr + XO(legacy.fpregs);
for (i = 0; i < 8; i++) {
- floatx80 tmp = helper_fldt(env, addr, ra);
+ floatx80 tmp = do_fldt(env, addr, ra);
ST(i) = tmp;
addr += 16;
}
--
2.26.2
- [PATCH v25 00/20] i386 cleanup PART 2, Claudio Fontana, 2021/02/26
- [PATCH v25 01/20] target/i386: Rename helper_fldt, helper_fstt,
Claudio Fontana <=
- [PATCH v25 02/20] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor, Claudio Fontana, 2021/02/26
- [PATCH v25 04/20] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/26
- [PATCH v25 03/20] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/02/26
- [PATCH v25 10/20] i386: split smm helper (sysemu), Claudio Fontana, 2021/02/26
- [PATCH v25 05/20] accel: introduce new accessor functions, Claudio Fontana, 2021/02/26
- [PATCH v25 06/20] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/26
- [PATCH v25 07/20] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/26
- [PATCH v25 08/20] meson: add target_user_arch, Claudio Fontana, 2021/02/26
- [PATCH v25 09/20] i386: split off sysemu-only functionality in tcg-cpu, Claudio Fontana, 2021/02/26
- [PATCH v25 13/20] i386: split misc helper user stubs and sysemu part, Claudio Fontana, 2021/02/26