Re: [PATCH v25 00/20] i386 cleanup PART 2

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v25 00/20] i386 cleanup PART 2

From:	no-reply
Subject:	Re: [PATCH v25 00/20] i386 cleanup PART 2
Date:	Fri, 26 Feb 2021 10:21:54 -0800 (PST)

Patchew URL: 20210226175143.22388-1-cfontana@suse.de/">https://patchew.org/QEMU/20210226175143.22388-1-cfontana@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210226175143.22388-1-cfontana@suse.de
Subject: [PATCH v25 00/20] i386 cleanup PART 2

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210224135255.253837-1-kwolf@redhat.com -> 
patchew/20210224135255.253837-1-kwolf@redhat.com
 - [tag update]      patchew/20210226170816.231173-1-pbonzini@redhat.com -> 
patchew/20210226170816.231173-1-pbonzini@redhat.com
 * [new tag]         patchew/20210226175143.22388-1-cfontana@suse.de -> 
patchew/20210226175143.22388-1-cfontana@suse.de
Switched to a new branch 'test'
02989cc i386: make cpu_load_efer sysemu-only
ac0598e target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu
757bbe0 target/i386: gdbstub: introduce aux functions to read/write CS64 regs
1e0f7f0 i386: split off sysemu part of cpu.c
e596c98 i386: split seg_helper into user-only and sysemu parts
0ae6534 i386: split svm_helper into sysemu and stub-only user
e790ea2 i386: separate fpu_helper into user and sysemu parts
142c4e4 i386: split misc helper user stubs and sysemu part
2d2ad9e i386: move TCG bpt_helper into sysemu/
9c22be4 i386: split tcg excp_helper into sysemu and user parts
7de5b93 i386: split smm helper (sysemu)
8509cdc i386: split off sysemu-only functionality in tcg-cpu
c76f124 meson: add target_user_arch
f085d0c accel-cpu: make cpu_realizefn return a bool
6269e36 target/i386: fix host_cpu_adjust_phys_bits error handling
3235fe1 accel: introduce new accessor functions
8e70f5e cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
663b0f6 i386: split cpu accelerators from cpu.c, using AccelCPUClass
b3dec13 target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor
af6cfbc target/i386: Rename helper_fldt, helper_fstt

=== OUTPUT BEGIN ===
1/20 Checking commit af6cfbce32fe (target/i386: Rename helper_fldt, helper_fstt)
2/20 Checking commit b3dec13f39d3 (target/i386: Split out do_fsave, do_frstor, 
do_fxsave, do_fxrstor)
3/20 Checking commit 663b0f6124f0 (i386: split cpu accelerators from cpu.c, 
using AccelCPUClass)
WARNING: line over 80 characters
#1337: FILE: target/i386/tcg/tcg-cpu.c:125:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 
0);

total: 0 errors, 1 warnings, 1256 lines checked

Patch 3/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/20 Checking commit 8e70f5e74a5b (cpu: call AccelCPUClass::cpu_realizefn in 
cpu_exec_realizefn)
5/20 Checking commit 3235fe1213b6 (accel: introduce new accessor functions)
6/20 Checking commit 6269e368a04f (target/i386: fix host_cpu_adjust_phys_bits 
error handling)
7/20 Checking commit f085d0ccbf1e (accel-cpu: make cpu_realizefn return a bool)
8/20 Checking commit c76f124aac0f (meson: add target_user_arch)
9/20 Checking commit 8509cdcb6f45 (i386: split off sysemu-only functionality in 
tcg-cpu)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

WARNING: line over 80 characters
#116: FILE: target/i386/tcg/sysemu/tcg-cpu.c:72:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 
0);

total: 0 errors, 2 warnings, 212 lines checked

Patch 9/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/20 Checking commit 7de5b93c44f8 (i386: split smm helper (sysemu))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
 target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++-----------------

total: 0 errors, 1 warnings, 84 lines checked

Patch 10/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/20 Checking commit 9c22be45905b (i386: split tcg excp_helper into sysemu and 
user parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#599: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#756: FILE: target/i386/tcg/sysemu/excp_helper.c:153:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is 
reserved.

WARNING: Block comments use a leading /* on a separate line
#830: FILE: target/i386/tcg/sysemu/excp_helper.c:227:
+/* return value:

WARNING: line over 80 characters
#931: FILE: target/i386/tcg/sysemu/excp_helper.c:328:
+            pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) 
<< 3)) &

WARNING: Block comments use a leading /* on a separate line
#1025: FILE: target/i386/tcg/sysemu/excp_helper.c:422:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is 
reserved.

WARNING: Block comments use a leading /* on a separate line
#1120: FILE: target/i386/tcg/sysemu/excp_helper.c:517:
+        /* only set write access if already dirty... otherwise wait

WARNING: Block comments use * on subsequent lines
#1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+        /* only set write access if already dirty... otherwise wait
+           for dirty access */

WARNING: Block comments use a trailing */ on a separate line
#1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+           for dirty access */

WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/i386/tcg/sysemu/excp_helper.c:531:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to

WARNING: Block comments use * on subsequent lines
#1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to
+       avoid filling it too fast */

WARNING: Block comments use a trailing */ on a separate line
#1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+       avoid filling it too fast */

ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/i386/tcg/sysemu/excp_helper.c:546:
+    if (is_user)
[...]

total: 1 errors, 11 warnings, 631 lines checked

Patch 11/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/20 Checking commit 2d2ad9ee372e (i386: move TCG bpt_helper into sysemu/)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#364: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#500: FILE: target/i386/tcg/sysemu/bpt_helper.c:132:
+    /* If nothing is changing except the global/local enable bits,

WARNING: Block comments use * on subsequent lines
#501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+    /* If nothing is changing except the global/local enable bits,
+       then we can make the change more efficient.  */

WARNING: Block comments use a trailing */ on a separate line
#501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+       then we can make the change more efficient.  */

WARNING: Block comments use a leading /* on a separate line
#503: FILE: target/i386/tcg/sysemu/bpt_helper.c:135:
+        /* Fold the global and local enable bits together into the

WARNING: Block comments use * on subsequent lines
#504: FILE: target/i386/tcg/sysemu/bpt_helper.c:136:
+        /* Fold the global and local enable bits together into the
+           global fields, then xor to show which registers have

WARNING: Block comments use a trailing */ on a separate line
#505: FILE: target/i386/tcg/sysemu/bpt_helper.c:137:
+           changed collective enable state.  */

total: 0 errors, 7 warnings, 628 lines checked

Patch 12/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/20 Checking commit 142c4e456755 (i386: split misc helper user stubs and 
sysemu part)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#526: 
new file mode 100644

ERROR: switch and case should be at the same indent
#819: FILE: target/i386/tcg/sysemu/misc_helper.c:289:
+    switch ((uint32_t)env->regs[R_ECX]) {
[...]
+     case MSR_IA32_UCODE_REV:

total: 1 errors, 1 warnings, 1012 lines checked

Patch 13/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/20 Checking commit e790ea2ac830 (i386: separate fpu_helper into user and 
sysemu parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#199: 
new file mode 100644

total: 0 errors, 1 warnings, 265 lines checked

Patch 14/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/20 Checking commit 0ae6534461a2 (i386: split svm_helper into sysemu and 
stub-only user)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
 target/i386/tcg/{ => sysemu}/svm_helper.c | 62 +------------------------

total: 0 errors, 1 warnings, 169 lines checked

Patch 15/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/20 Checking commit e596c98c85c8 (i386: split seg_helper into user-only and 
sysemu parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#321: 
new file mode 100644

ERROR: do not use C99 // comments
#348: FILE: target/i386/tcg/seg_helper.h:23:
+//#define DEBUG_PCALL

WARNING: Block comments use a leading /* on a separate line
#621: FILE: target/i386/tcg/user/seg_helper.c:73:
+    /* Since we emulate only user space, we cannot do more than

WARNING: Block comments use * on subsequent lines
#622: FILE: target/i386/tcg/user/seg_helper.c:74:
+    /* Since we emulate only user space, we cannot do more than
+       exiting the emulation with the suitable exception and error

WARNING: Block comments use a trailing */ on a separate line
#623: FILE: target/i386/tcg/user/seg_helper.c:75:
+       code. So update EIP for INT 0x80 and EXCP_SYSCALL. */

WARNING: Block comments use a leading /* on a separate line
#634: FILE: target/i386/tcg/user/seg_helper.c:86:
+    /* if user mode only, we simulate a fake exception

WARNING: Block comments use * on subsequent lines
#635: FILE: target/i386/tcg/user/seg_helper.c:87:
+    /* if user mode only, we simulate a fake exception
+       which will be handled outside the cpu execution

WARNING: Block comments use a trailing */ on a separate line
#636: FILE: target/i386/tcg/user/seg_helper.c:88:
+       loop */

total: 1 errors, 7 warnings, 595 lines checked

Patch 16/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/20 Checking commit 1e0f7f03119e (i386: split off sysemu part of cpu.c)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#52: FILE: target/i386/cpu-internal.h:30:
+    /* feature flags names are taken from "Intel Processor Identification and

WARNING: Block comments use a leading /* on a separate line
#135: FILE: target/i386/cpu-sysemu.c:37:
+/* Return a QDict containing keys for all properties that can be included

WARNING: Block comments use a leading /* on a separate line
#188: FILE: target/i386/cpu-sysemu.c:90:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#202: FILE: target/i386/cpu-sysemu.c:104:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#218: FILE: target/i386/cpu-sysemu.c:120:
+        /* "hotplugged" is the only property that is configurable

WARNING: Block comments use a leading /* on a separate line
#308: FILE: target/i386/cpu-sysemu.c:210:
+        /* As we don't return every single property, full expansion needs

total: 0 errors, 7 warnings, 901 lines checked

Patch 17/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit 757bbe04d966 (target/i386: gdbstub: introduce aux 
functions to read/write CS64 regs)
WARNING: line over 80 characters
#62: FILE: target/i386/gdbstub.c:163:
+            return gdb_read_reg_cs64(env->hflags, mem_buf, 
env->segs[R_FS].base);

WARNING: line over 80 characters
#68: FILE: target/i386/gdbstub.c:165:
+            return gdb_read_reg_cs64(env->hflags, mem_buf, 
env->segs[R_GS].base);

WARNING: line over 80 characters
#156: FILE: target/i386/gdbstub.c:318:
+            return gdb_write_reg_cs64(env->hflags, mem_buf, 
&env->segs[R_FS].base);

WARNING: line over 80 characters
#165: FILE: target/i386/gdbstub.c:320:
+            return gdb_write_reg_cs64(env->hflags, mem_buf, 
&env->segs[R_GS].base);

total: 0 errors, 4 warnings, 221 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit ac0598ea79fa (target/i386: gdbstub: only write 
CR0/CR2/CR3/EFER for sysemu)
20/20 Checking commit 02989cc5ab1e (i386: make cpu_load_efer sysemu-only)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210226175143.22388-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20210226175143.22388-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v25 15/20] i386: split svm_helper into sysemu and stub-only user, (continued)
- [PATCH v25 15/20] i386: split svm_helper into sysemu and stub-only user, Claudio Fontana, 2021/02/26
- [PATCH v25 16/20] i386: split seg_helper into user-only and sysemu parts, Claudio Fontana, 2021/02/26
- [PATCH v25 11/20] i386: split tcg excp_helper into sysemu and user parts, Claudio Fontana, 2021/02/26
- [PATCH v25 17/20] i386: split off sysemu part of cpu.c, Claudio Fontana, 2021/02/26
- [PATCH v25 19/20] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu, Claudio Fontana, 2021/02/26
- [PATCH v25 12/20] i386: move TCG bpt_helper into sysemu/, Claudio Fontana, 2021/02/26
- [PATCH v25 14/20] i386: separate fpu_helper into user and sysemu parts, Claudio Fontana, 2021/02/26
  - Re: [PATCH v25 14/20] i386: separate fpu_helper into user and sysemu parts, Richard Henderson, 2021/02/26
- [PATCH v25 18/20] target/i386: gdbstub: introduce aux functions to read/write CS64 regs, Claudio Fontana, 2021/02/26
- [PATCH v25 20/20] i386: make cpu_load_efer sysemu-only, Claudio Fontana, 2021/02/26
- Re: [PATCH v25 00/20] i386 cleanup PART 2, no-reply <=

Prev by Date: Re: [QEMU-SECURITY] [PATCH 1/6] net: introduce qemu_receive_packet()
Next by Date: Re: [PATCH v25 13/20] i386: split misc helper user stubs and sysemu part
Previous by thread: [PATCH v25 20/20] i386: make cpu_load_efer sysemu-only
Next by thread: [Bug 1917082] [NEW] [OSS-Fuzz] Issue 27574 e1000: Loopback-related stack-overflow
Index(es):
- Date
- Thread