[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration |
Date: |
Fri, 05 Mar 2021 09:06:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
>> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
>>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
>>> configuring floppies with -global isa-fdc" (v5.1.0).
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
> Sadly, the commit's update of docs/system/deprecated.rst neglects to
> cover this use. Looks the series overtaxed my capacity to juggle
> details; my apologies.
[...]
I'm talking about commit 4a27a638e7 here.
The deprecated.rst text only covers setting floppy controller properties
with -global. It neglects to cover setting them with -device. For
onboard controllers, -global is the only way to set them.
I append a fixup.
We can put it before this patch. This patch then moves the fixed up
text to removed-features.rst.
Or we squash it into this patch, i.e. this patch deletes the flawed text
from deprecated.rst and adds the fixed up text to removed-features.rst.
Got a preference?
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 2fcac7861e..393ede47f1 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -97,7 +97,11 @@ QEMU 5.1 has three options:
``Configuring floppies with ``-global``
'''''''''''''''''''''''''''''''''''''''
-Use ``-device floppy,...`` instead:
+Floppy controllers' drive properties (since 5.1)
+''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use ``-device floppy,...`` instead. When configuring onboard floppy
+controllers
::
-global isa-fdc.driveA=...
@@ -120,8 +124,30 @@ become
-device floppy,unit=1,drive=...
-``-drive`` with bogus interface type
-''''''''''''''''''''''''''''''''''''
+When plugging in a floppy controller
+::
+
+ -device isa-fdc,...,driveA=...
+
+becomes
+::
+
+ -device isa-fdc,...
+ -device floppy,unit=0,drive=...
+
+and
+::
+
+ -device isa-fdc,...,driveB=...
+
+becomes
+::
+
+ -device isa-fdc,...
+ -device floppy,unit=1,drive=...
+
+``-drive`` with bogus interface type (since 5.1)
+''''''''''''''''''''''''''''''''''''''''''''''''
Drives with interface types other than ``if=none`` are for onboard
devices. It is possible to use drives the board doesn't pick up with
- [PATCH v2 0/3] Drop deprecated floppy config & bogus -drive if=T, Markus Armbruster, 2021/03/04
- [PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common(), Markus Armbruster, 2021/03/04
- [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Peter Krempa, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/05
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration,
Markus Armbruster <=
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/08
[PATCH v2 3/3] blockdev: Drop deprecated bogus -drive interface type, Markus Armbruster, 2021/03/04