Re: [PATCH v2] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

[Daniel P . Berrangé]

On Tue, Mar 09, 2021 at 05:50:35PM +0100, Thomas Huth wrote:
> When trying to remove the -usbdevice option, there were complaints that
> "-usbdevice braille" is still a very useful shortcut for some people.
> Thus we never remove this option. Since it's not such a big burden to
> keep it around, and it's also convenient in the sense that you don't
> have to worry to enable a host controller explicitly with this option,
> we should remove it from he deprecation list again, and rather properly
> document the possible device for this option instead.
> 
> However, there is one exception: "-usbdevice audio" should go away, since
> audio devices without "audiodev=..." parameter are also on the deprecation
> list and you cannot use "-usbdevice audio" with "audiodev".
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Add an entry to removed-features.rst
> 
>  docs/system/deprecated.rst       |  9 --------
>  docs/system/removed-features.rst |  8 +++++++
>  hw/usb/dev-audio.c               |  1 -
>  qemu-options.hx                  | 38 +++++++++++++++++++++++++++-----
>  softmmu/vl.c                     |  2 --
>  5 files changed, 40 insertions(+), 18 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|