[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval |
Date: |
Wed, 10 Mar 2021 09:47:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Le 10/03/2021 à 09:09, Mark Cave-Ayland a écrit :
> The 60Hz timer is initialised using timer_new_ns() meaning that the timer
> interval should be measured in ns, and therefore its period is a thousand
> times too short.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/misc/mac_via.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c
> index f994fefa7c..c6e1552a59 100644
> --- a/hw/misc/mac_via.c
> +++ b/hw/misc/mac_via.c
> @@ -302,8 +302,8 @@ static void via1_sixty_hz_update(MOS6522Q800VIA1State
> *v1s)
> MOS6522State *s = MOS6522(v1s);
>
> /* 60 Hz irq */
> - v1s->next_sixty_hz = (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 16630) /
> - 16630 * 16630;
> + v1s->next_sixty_hz = (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 16630000) /
> + 16630000 * 16630000;
>
> if (s->ier & VIA1_IRQ_60HZ) {
> timer_mod(v1s->sixty_hz_timer, v1s->next_sixty_hz);
>
Reviewed-by: Laurent Vivier <laurent@vivier.Eu>
- [PATCH 1/7] mac_via: switch rtc pram trace-events to use hex rather than decimal for addresses, (continued)
- [PATCH 1/7] mac_via: switch rtc pram trace-events to use hex rather than decimal for addresses, Mark Cave-Ayland, 2021/03/10
- [PATCH 2/7] mac_via: fix up adb_via_receive() trace events, Mark Cave-Ayland, 2021/03/10
- [PATCH 3/7] mac_via: allow long accesses to VIA registers, Mark Cave-Ayland, 2021/03/10
- [PATCH 4/7] mac_via: don't re-inject ADB response when switching to IDLE state, Mark Cave-Ayland, 2021/03/10
- [PATCH 5/7] mac_via: rename VBL timer to 60Hz timer, Mark Cave-Ayland, 2021/03/10
- [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Mark Cave-Ayland, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval,
Laurent Vivier <=
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, BALATON Zoltan, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Laurent Vivier, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Laurent Vivier, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Laurent Vivier, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Mark Cave-Ayland, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, BALATON Zoltan, 2021/03/10
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Mark Cave-Ayland, 2021/03/11
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Laurent Vivier, 2021/03/11
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Mark Cave-Ayland, 2021/03/11
- Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval, Philippe Mathieu-Daudé, 2021/03/10