qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/i8254: fix vmstate load


From: Paolo Bonzini
Subject: Re: [PATCH] hw/i8254: fix vmstate load
Date: Wed, 10 Mar 2021 11:27:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 10/03/21 11:21, Pavel Dovgalyuk wrote:
QEMU timer of channel 0 in i8254 is used to raise irq
at the specified moment of time. This irq can be disabled
with irq_disabled flag. But when vmstate of the pit is
loaded, timer may be rearmed despite the disabled interrupts.
This patch adds irq_disabled flag check to fix that.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
  hw/timer/i8254.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/timer/i8254.c b/hw/timer/i8254.c
index c01ee2c72a..c8388ea432 100644
--- a/hw/timer/i8254.c
+++ b/hw/timer/i8254.c
@@ -324,7 +324,7 @@ static void pit_post_load(PITCommonState *s)
  {
      PITChannelState *sc = &s->channels[0];
- if (sc->next_transition_time != -1) {
+    if (sc->next_transition_time != -1 && !sc->irq_disabled) {
          timer_mod(sc->irq_timer, sc->next_transition_time);
      } else {
          timer_del(sc->irq_timer);


Queued, thanks.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]