[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID |
Date: |
Wed, 10 Mar 2021 14:29:20 +0100 |
Hi,
> -static void xenfb_update_interval(void *opaque, uint64_t interval)
> +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
> - .update_interval = xenfb_update_interval,
> + .ui_info = xenfb_ui_info,
Hmm, I suspect xenfb really wants the actual refresh rate, even in case
vnc/sdl change it dynamically. Anthony? Stefano?
I guess we should just leave the update_interval callback as-is, for
those who want know, and use ui_info->refresh_rate for the virtual edid
refresh rate (which may not match the actual update interval in case of
dynamic changes). Adding a comment explaining the difference to
console.h is a good idea too.
Otherwise looks good to me overall. Splitting the ui/gtk update to a
separate patch is probably a good idea.
take care,
Gerd