[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/12] hw/block/pflash_cfi02: Add DeviceReset method
From: |
David Edmondson |
Subject: |
Re: [PATCH v2 08/12] hw/block/pflash_cfi02: Add DeviceReset method |
Date: |
Wed, 10 Mar 2021 17:31:57 +0000 |
On Wednesday, 2021-03-10 at 18:05:24 +01, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> hw/block/pflash_cfi02.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index aea47a99c61..c40febd2a41 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -942,6 +942,13 @@ static void pflash_cfi02_realize(DeviceState *dev, Error
> **errp)
> pflash_cfi02_fill_cfi_table(pfl, nb_regions);
> }
>
> +static void pflash_cfi02_reset(DeviceState *dev)
> +{
> + PFlashCFI02 *pfl = PFLASH_CFI02(dev);
> +
> + pflash_reset_state_machine(pfl);
> +}
> +
> static Property pflash_cfi02_properties[] = {
> DEFINE_PROP_DRIVE("drive", PFlashCFI02, blk),
> DEFINE_PROP_UINT32("num-blocks", PFlashCFI02, uniform_nb_blocs, 0),
> @@ -979,6 +986,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass,
> void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> dc->realize = pflash_cfi02_realize;
> + dc->reset = pflash_cfi02_reset;
> dc->unrealize = pflash_cfi02_unrealize;
> device_class_set_props(dc, pflash_cfi02_properties);
> set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> --
> 2.26.2
dme.
--
Stop the music and go home.
- [PATCH v2 03/12] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table(), (continued)
- [PATCH v2 03/12] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table(), Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 04/12] hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings(), Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 05/12] hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false), Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 06/12] hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array, Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 07/12] hw/block/pflash_cfi02: Factor out pflash_reset_state_machine(), Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 08/12] hw/block/pflash_cfi02: Add DeviceReset method, Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 09/12] hw/block/pflash_cfi01: Clarify trace events, Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 10/12] hw/block/pflash_cfi01: Extract pflash_mode_read_array(), Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 11/12] hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro, Philippe Mathieu-Daudé, 2021/03/10
- [PATCH v2 12/12] hw/block/pflash_cfi: Replace DPRINTF with trace events, Philippe Mathieu-Daudé, 2021/03/10
- Re: [PATCH v2 00/12] hw/block/pflash: Refactors around setting the device in read-array mode, Philippe Mathieu-Daudé, 2021/03/15