Re: [PATCH v3 2/3] target/arm: Add support for FEAT_TLBIOS

[Richard Henderson]

On 3/9/21 6:29 PM, Rebecca Cran wrote:
> +static inline bool isar_feature_aa64_tlbios(const ARMISARegisters *id)
> +{
> +    return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, TLB) == 1 ||
> +           FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, TLB) == 2;
> +}

The correct test here is != 0.  See D13.1.3
Principles of the ID scheme for fields in ID registers.


r~