[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 24/29] tcg: Do not set guard pages in the rx buffer
From: |
Richard Henderson |
Subject: |
[PATCH v2 24/29] tcg: Do not set guard pages in the rx buffer |
Date: |
Sun, 14 Mar 2021 15:27:19 -0600 |
We only need guard pages in the rw buffer to avoid buffer overruns.
Let the rx buffer keep large pages all the way through.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/region.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/tcg/region.c b/tcg/region.c
index 994c083343..27a7e35c8e 100644
--- a/tcg/region.c
+++ b/tcg/region.c
@@ -839,7 +839,6 @@ void tcg_region_init(size_t tb_size, int splitwx, unsigned
max_cpus)
size_t page_size;
size_t region_size;
size_t i;
- uintptr_t splitwx_diff;
int have_prot;
have_prot = alloc_code_gen_buffer(size_code_gen_buffer(tb_size),
@@ -881,8 +880,7 @@ void tcg_region_init(size_t tb_size, int splitwx, unsigned
max_cpus)
/* init the region struct */
qemu_mutex_init(®ion.lock);
- /* set guard pages */
- splitwx_diff = tcg_splitwx_diff;
+ /* Set guard pages. No need to do this for the rx_buf, only the rw_buf. */
for (i = 0; i < region.n; i++) {
void *start, *end;
int rc;
@@ -890,10 +888,6 @@ void tcg_region_init(size_t tb_size, int splitwx, unsigned
max_cpus)
tcg_region_bounds(i, &start, &end);
rc = qemu_mprotect_none(end, page_size);
g_assert(!rc);
- if (splitwx_diff) {
- rc = qemu_mprotect_none(end + splitwx_diff, page_size);
- g_assert(!rc);
- }
}
tcg_region_trees_init();
--
2.25.1
- [PATCH v2 13/29] accel/tcg: Pass down max_cpus to tcg_init, (continued)
- [PATCH v2 13/29] accel/tcg: Pass down max_cpus to tcg_init, Richard Henderson, 2021/03/14
- [PATCH v2 14/29] tcg: Introduce tcg_max_ctxs, Richard Henderson, 2021/03/14
- [PATCH v2 15/29] tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h, Richard Henderson, 2021/03/14
- [PATCH v2 16/29] tcg: Replace region.end with region.total_size, Richard Henderson, 2021/03/14
- [PATCH v2 20/29] tcg: Move in_code_gen_buffer and tests to region.c, Richard Henderson, 2021/03/14
- [PATCH v2 17/29] tcg: Rename region.start to region.after_prologue, Richard Henderson, 2021/03/14
- [PATCH v2 19/29] tcg: Tidy split_cross_256mb, Richard Henderson, 2021/03/14
- [PATCH v2 18/29] tcg: Tidy tcg_n_regions, Richard Henderson, 2021/03/14
- [PATCH v2 23/29] tcg: Sink qemu_madvise call to common code, Richard Henderson, 2021/03/14
- [PATCH v2 26/29] tcg: Round the tb_size default from qemu_get_host_physmem, Richard Henderson, 2021/03/14
- [PATCH v2 24/29] tcg: Do not set guard pages in the rx buffer,
Richard Henderson <=
- [PATCH v2 28/29] tcg: When allocating for !splitwx, begin with PROT_NONE, Richard Henderson, 2021/03/14
- [PATCH v2 29/29] tcg: Move tcg_init_ctx and tcg_ctx from accel/tcg/, Richard Henderson, 2021/03/14
- [PATCH v2 25/29] util/osdep: Add qemu_mprotect_rw, Richard Henderson, 2021/03/14
- [PATCH v2 21/29] tcg: Allocate code_gen_buffer into struct tcg_region_state, Richard Henderson, 2021/03/14
- [PATCH v2 27/29] tcg: Merge buffer protection and guard page protection, Richard Henderson, 2021/03/14
- [PATCH v2 22/29] tcg: Return the map protection from alloc_code_gen_buffer, Richard Henderson, 2021/03/14
- Re: [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug, no-reply, 2021/03/14
- Re: [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug, Roman Bolshakov, 2021/03/15