[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd |
Date: |
Mon, 15 Mar 2021 15:34:34 +0000 |
On Mon, Mar 08, 2021 at 07:31:25AM +0100, Thomas Huth wrote:
> On 22/02/2021 17.10, Stefan Hajnoczi wrote:
> > For some reason memfd never used share=on. vhost-user relies on
> > mmap(MAP_SHARED) so this seems like a problem, but the tests still run
> > without it.
> >
> > Add share=on for consistency and to prevent future bugs in the test.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > tests/qtest/vhost-user-test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> > index 1a5f5313ff..2db98c4920 100644
> > --- a/tests/qtest/vhost-user-test.c
> > +++ b/tests/qtest/vhost-user-test.c
> > @@ -40,7 +40,7 @@
> > #define QEMU_CMD_MEM " -m %d -object
> > memory-backend-file,id=mem,size=%dM," \
> > "mem-path=%s,share=on -numa node,memdev=mem"
> > #define QEMU_CMD_MEMFD " -m %d -object
> > memory-backend-memfd,id=mem,size=%dM," \
> > - " -numa node,memdev=mem"
> > + "share=on -numa node,memdev=mem"
>
> Even if it's not required, it seems to be a good clean up, also with regards
> to the lonely comma at the end of the previous line.
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> I assume this will go through the vhost tree, or do you want me to take this
> single patch through my qtest tree?
I think this entire series will go through the vhost tree.
Thanks,
Stefan
signature.asc
Description: PGP signature