[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP intr
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection |
Date: |
Mon, 15 Mar 2021 11:13:19 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> This policy suppresses deprecated bits in output, and thus permits
> "testing the future". Implement it for QMP command query-qmp-schema:
> suppress information on deprecated commands, events and object type
> members, i.e. anything that has the special feature flag "deprecated".
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> monitor/qmp-cmds-control.c | 71 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/monitor/qmp-cmds-control.c b/monitor/qmp-cmds-control.c
> index 25afd0867f..bcfccc4ac4 100644
> --- a/monitor/qmp-cmds-control.c
> +++ b/monitor/qmp-cmds-control.c
> @@ -158,6 +158,74 @@ EventInfoList *qmp_query_events(Error **errp)
> return ev_list;
> }
>
> +static void *split_off_generic_list(void *list,
> + bool (*splitp)(void *elt),
> + void **part)
> +{
> + GenericList *keep = NULL, **keep_tailp = &keep;
> + GenericList *split = NULL, **split_tailp = &split;
> + GenericList *tail;
> +
> + for (tail = list; tail; tail = tail->next) {
> + if (splitp(tail)) {
> + *split_tailp = tail;
> + split_tailp = &tail->next;
> + } else {
> + *keep_tailp = tail;
> + keep_tailp = &tail->next;
> + }
> + }
At first glance, I wondered if QAPI_LIST_APPEND would be better than
open coding, but with a bit more thought, I agree that this particular
case is best written as presented (you are manipulating two tail
pointers in one iteration, which is different semantics than
QAPI_LIST_APPEND advancing a single tail pointer).
R-b still stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, (continued)
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12
- [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection,
Eric Blake <=
- [PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2021/03/12
- [PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/18