[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz
|
From: |
Eric Blake |
|
Subject: |
Re: [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz |
|
Date: |
Mon, 15 Mar 2021 14:11:45 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/15/21 1:51 PM, Richard Henderson wrote:
> Once we've parsed the fractional value, extract it into an integral
> 64-bit fraction. Perform the scaling with integer arithmetic, and
> simplify the overflow detection.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Message-Id: <20210315155835.1970210-2-richard.henderson@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
A bit late now that it's in a pull request, but adding
Fixes: cf923b783efd5 (utils: Improve qemu_strtosz() to have 64 bits of
precision)
would have been nice.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org