[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 8/9] edid: allow arbitrary-length checksums
From: |
Gerd Hoffmann |
Subject: |
[PATCH 8/9] edid: allow arbitrary-length checksums |
Date: |
Tue, 16 Mar 2021 15:38:11 +0100 |
From: Konstantin Nazarov <mail@knazarov.com>
Some of the EDID extensions like DisplayID do checksums of their
subsections. Currently checksums can be only applied to the whole
extension blocks which are 128 bytes.
This patch allows to checksum arbitrary parts of EDID, and not only
whole extension blocks.
Based-on: <20210303152948.59943-2-akihiko.odaki@gmail.com>
Signed-off-by: Konstantin Nazarov <mail@knazarov.com>
Message-Id: <20210315114639.91953-2-mail@knazarov.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/edid-generate.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index b70ab1557e50..bdd01571fc9b 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -159,17 +159,17 @@ static void edid_fill_modes(uint8_t *edid, uint8_t
*xtra3, uint8_t *dta,
}
}
-static void edid_checksum(uint8_t *edid)
+static void edid_checksum(uint8_t *edid, size_t len)
{
uint32_t sum = 0;
int i;
- for (i = 0; i < 127; i++) {
+ for (i = 0; i < len; i++) {
sum += edid[i];
}
sum &= 0xff;
if (sum) {
- edid[127] = 0x100 - sum;
+ edid[len] = 0x100 - sum;
}
}
@@ -474,9 +474,9 @@ void qemu_edid_generate(uint8_t *edid, size_t size,
/* =============== finish up =============== */
- edid_checksum(edid);
+ edid_checksum(edid, 127);
if (dta) {
- edid_checksum(dta);
+ edid_checksum(dta, 127);
}
}
--
2.30.2
- [PATCH 0/9] edid: windows fixes, Gerd Hoffmann, 2021/03/16
- [PATCH 3/9] edid: move xtra3 descriptor, Gerd Hoffmann, 2021/03/16
- [PATCH 4/9] edid: use dta extension block descriptors, Gerd Hoffmann, 2021/03/16
- [PATCH 2/9] edid: edid_desc_next, Gerd Hoffmann, 2021/03/16
- [PATCH 8/9] edid: allow arbitrary-length checksums,
Gerd Hoffmann <=
- [PATCH 1/9] qemu-edid: use qemu_edid_size(), Gerd Hoffmann, 2021/03/16
- [PATCH 9/9] edid: add support for DisplayID extension (5k resolution), Gerd Hoffmann, 2021/03/16
- [PATCH 5/9] edid: prefer standard timings, Gerd Hoffmann, 2021/03/16
- [PATCH 6/9] edid: Make refresh rate configurable, Gerd Hoffmann, 2021/03/16
- [PATCH 7/9] edid: move timing generation into a separate function, Gerd Hoffmann, 2021/03/16
- Re: [PATCH 0/9] edid: windows fixes, no-reply, 2021/03/16