[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc |
Date: |
Tue, 16 Mar 2021 23:55:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/11/21 3:39 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/tcg/tci.c b/tcg/tci.c
> index 1c879a2536..bdd2127ec8 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -207,6 +207,15 @@ static void tci_args_rrs(const uint8_t **tb_ptr,
> *i2 = tci_read_s32(tb_ptr);
> }
>
> +static void tci_args_rrrc(const uint8_t **tb_ptr,
> + TCGReg *r0, TCGReg *r1, TCGReg *r2, TCGCond *c3)
> +{
> + *r0 = tci_read_r(tb_ptr);
> + *r1 = tci_read_r(tb_ptr);
> + *r2 = tci_read_r(tb_ptr);
> + *c3 = tci_read_b(tb_ptr);
> +}
Can you describe 'c -> cond' in the previous comment?
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v5 00/57] TCI fixes and cleanups, Richard Henderson, 2021/03/11
- [PATCH v5 01/57] tcg/tci: Remove ifdefs for TCG_TARGET_HAS_ext32[us]_i64, Richard Henderson, 2021/03/11
- [PATCH v5 02/57] tcg/tci: Rename tci_read_r to tci_read_rval, Richard Henderson, 2021/03/11
- [PATCH v5 03/57] tcg/tci: Split out tci_args_rrs, Richard Henderson, 2021/03/11
- [PATCH v5 05/57] tcg/tci: Split out tci_args_rrr, Richard Henderson, 2021/03/11
- [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc, Richard Henderson, 2021/03/11
- Re: [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc,
Philippe Mathieu-Daudé <=
- [PATCH v5 04/57] tcg/tci: Split out tci_args_rr, Richard Henderson, 2021/03/11
- [PATCH v5 07/57] tcg/tci: Split out tci_args_l, Richard Henderson, 2021/03/11
- [PATCH v5 09/57] tcg/tci: Split out tci_args_rrcl and tci_args_rrrrcl, Richard Henderson, 2021/03/11
- [PATCH v5 08/57] tcg/tci: Split out tci_args_rrrrrc, Richard Henderson, 2021/03/11
- [PATCH v5 10/57] tcg/tci: Split out tci_args_ri and tci_args_rI, Richard Henderson, 2021/03/11