Re: [PATCH v2 0/7] ui: add vdagent implementation and clipboard support.

[no-reply]

Patchew URL: 
20210318091647.3233178-1-kraxel@redhat.com/">https://patchew.org/QEMU/20210318091647.3233178-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210318091647.3233178-1-kraxel@redhat.com
Subject: [PATCH v2 0/7] ui: add vdagent implementation and clipboard support.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210317143325.2165821-1-eblake@redhat.com -> 
patchew/20210317143325.2165821-1-eblake@redhat.com
 - [tag update]      patchew/20210317194849.2262346-1-wainersm@redhat.com -> 
patchew/20210317194849.2262346-1-wainersm@redhat.com
 - [tag update]      patchew/20210318023801.18287-1-gshan@redhat.com -> 
patchew/20210318023801.18287-1-gshan@redhat.com
 * [new tag]         patchew/20210318091647.3233178-1-kraxel@redhat.com -> 
patchew/20210318091647.3233178-1-kraxel@redhat.com
Switched to a new branch 'test'
509f0ec ui/gtk: add clipboard support
6413531 ui/gtk: move struct GtkDisplayState to ui/gtk.h
be4f996 ui/vnc: clipboard support
15ab2b9 ui/vdagent: add clipboard support
c920715 ui/vdagent: add mouse support
d23759f ui/vdagent: core infrastructure
f59e025 ui: add clipboard infrastructure

=== OUTPUT BEGIN ===
1/7 Checking commit f59e025bdd71 (ui: add clipboard infrastructure)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 167 lines checked

Patch 1/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/7 Checking commit d23759fc5d14 (ui/vdagent: core infrastructure)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#91: 
new file mode 100644

ERROR: if this code is redundant consider removing it
#141: FILE: ui/vdagent.c:46:
+#if 0

WARNING: line over 80 characters
#143: FILE: ui/vdagent.c:48:
+    [VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = 
"clipboard-no-release-on-regrab",

ERROR: if this code is redundant consider removing it
#164: FILE: ui/vdagent.c:69:
+#if 0

WARNING: line over 80 characters
#216: FILE: ui/vdagent.c:121:
+                                               
sizeof(VDAgentAnnounceCapabilities) +

total: 2 errors, 3 warnings, 322 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit c9207151ac3c (ui/vdagent: add mouse support)
ERROR: if this code is redundant consider removing it
#137: FILE: ui/vdagent.c:179:
+#if 0

total: 1 errors, 0 warnings, 228 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit 15ab2b94f99a (ui/vdagent: add clipboard support)
ERROR: if this code is redundant consider removing it
#120: FILE: ui/vdagent.c:112:
+#if 0

ERROR: line over 90 characters
#159: FILE: ui/vdagent.c:286:
+                                               sizeof(uint32_t) * 
(QEMU_CLIPBOARD_TYPE__COUNT + 1));

WARNING: line over 80 characters
#406: FILE: ui/vdagent.c:652:
+    cfg->clipboard = qemu_opt_get_bool(opts, "clipboard", 
VDAGENT_CLIPBOARD_DEFAULT);

total: 2 errors, 1 warnings, 359 lines checked

Patch 4/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/7 Checking commit be4f996a546c (ui/vnc: clipboard support)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

WARNING: line over 80 characters
#280: FILE: ui/vnc-clipboard.c:243:
+void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, 
uint8_t *data)

WARNING: line over 80 characters
#289: FILE: ui/vnc-clipboard.c:252:
+            qemu_clipboard_info_new(&vs->cbpeer, 
QEMU_CLIPBOARD_SELECTION_CLIPBOARD);

WARNING: line over 80 characters
#333: FILE: ui/vnc-clipboard.c:296:
+        qemu_clipboard_info_new(&vs->cbpeer, 
QEMU_CLIPBOARD_SELECTION_CLIPBOARD);

ERROR: line over 90 characters
#420: FILE: ui/vnc.c:2430:
+            vnc_client_cut_text_ext(vs, abs(read_s32(data, 4)), read_u32(data, 
8), data + 12);

WARNING: line over 80 characters
#499: FILE: ui/vnc.h:643:
+void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, 
uint8_t *data);

total: 1 errors, 5 warnings, 450 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 6413531353b7 (ui/gtk: move struct GtkDisplayState to 
ui/gtk.h)
7/7 Checking commit 509f0ec4d648 (ui/gtk: add clipboard support)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

WARNING: line over 80 characters
#135: FILE: ui/gtk-clipboard.c:79:
+    GtkDisplayState *gd = container_of(notifier, GtkDisplayState, 
cbpeer.update);

total: 0 errors, 2 warnings, 230 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210318091647.3233178-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210318091647.3233178-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com