Re: [PULL v4 0/6] QOM and fdc patches patches for 2021-03-16

[Markus Armbruster]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 19 Mar 2021 at 06:45, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The following changes since commit 8a40754bca14df63c6d2ffe473b68a270dc50679:
>>
>>   Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' 
>> into staging (2021-03-18 19:55:37 +0000)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v4
>>
>> for you to fetch changes up to 0c727a621a646504ccec2b08e55fd48030448466:
>>
>>   memory: Drop "qemu:" prefix from QOM memory region type names (2021-03-19 
>> 06:55:49 +0100)
>>
>> ----------------------------------------------------------------
>> QOM and fdc patches patches for 2021-03-16
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (6):
>>       docs/system/deprecated: Fix note on fdc drive properties
>>       fdc: Drop deprecated floppy configuration
>>       fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
>>       blockdev: Drop deprecated bogus -drive interface type
>>       hw: Replace anti-social QOM type names
>>       memory: Drop "qemu:" prefix from QOM memory region type name
>
> Looks like this breaks the sanitizer gitlab CI job:
>  https://gitlab.com/qemu-project/qemu/-/jobs/1111697105
>
> Testing ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3
> ...
> ==8556==WARNING: ASan doesn't fully support makecontext/swapcontext
> functions and may produce false positives in some cases!
> ==8556==WARNING: ASan is ignoring requested __asan_handle_no_return:
> stack type: default top: 0x7ffcb7805000; bottom 0x7f960e9fd000; size:
> 0x0066a8e08000 (440919949312)
> False positive error reports may follow
> For details see https://github.com/google/sanitizers/issues/189
> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive:
> machine type does not support if=sd,bus=0,unit=0

In tests/qtest/fuzz/generic_fuzz_configs.h:

    },{
        .name = "sdhci-v3",
        .args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
        "-device sd-card,drive=mydrive "
        "-drive if=sd,index=0,file=null-co://,format=raw,id=mydrive -nographic",
        .objects = "sd*"
    },{

The if=sd needs to be if=none.

Before this series, the test prints a deprecation warning.  Since it
also prints lots of other junk, nobody noticed.

After this series removed the deprecated misfeature, the test fails.

v5 coming.