[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC
From: |
David Gibson |
Subject: |
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC |
Date: |
Tue, 23 Mar 2021 11:08:37 +1100 |
On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> min_frame_len should excluce CRC, so it should be 60 instead of 64.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Applied to ppc-for-6.0, thanks.
> ---
>
> hw/net/fsl_etsec/rings.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index d6be0d7d18..8f08446415 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -259,7 +259,7 @@ static void process_tx_bd(eTSEC *etsec,
> || etsec->regs[MACCFG2].value & MACCFG2_PADCRC) {
>
> /* Padding and CRC (Padding implies CRC) */
> - tx_padding_and_crc(etsec, 64);
> + tx_padding_and_crc(etsec, 60);
>
> } else if (etsec->first_bd.flags & BD_TX_TC
> || etsec->regs[MACCFG2].value & MACCFG2_CRC_EN) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC,
David Gibson <=