[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/9] simplebench: bench_one(): add slow_limit argument
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v3 1/9] simplebench: bench_one(): add slow_limit argument |
Date: |
Tue, 23 Mar 2021 16:47:26 +0300 |
Sometimes one of cells in a testing table runs too slow. And we really
don't want to wait so long. Limit number of runs in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
scripts/simplebench/simplebench.py | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/scripts/simplebench/simplebench.py
b/scripts/simplebench/simplebench.py
index f61513af90..0a3035732c 100644
--- a/scripts/simplebench/simplebench.py
+++ b/scripts/simplebench/simplebench.py
@@ -19,9 +19,11 @@
#
import statistics
+import time
-def bench_one(test_func, test_env, test_case, count=5, initial_run=True):
+def bench_one(test_func, test_env, test_case, count=5, initial_run=True,
+ slow_limit=100):
"""Benchmark one test-case
test_func -- benchmarking function with prototype
@@ -36,6 +38,8 @@ def bench_one(test_func, test_env, test_case, count=5,
initial_run=True):
test_case -- test case - opaque second argument for test_func
count -- how many times to call test_func, to calculate average
initial_run -- do initial run of test_func, which don't get into result
+ slow_limit -- stop at slow run (that exceedes the slow_limit by seconds).
+ (initial run is not measured)
Returns dict with the following fields:
'runs': list of test_func results
@@ -53,11 +57,19 @@ def bench_one(test_func, test_env, test_case, count=5,
initial_run=True):
runs = []
for i in range(count):
+ t = time.time()
+
print(' #run {}'.format(i+1))
res = test_func(test_env, test_case)
print(' ', res)
runs.append(res)
+ if time.time() - t > slow_limit:
+ print(' - run is too slow, stop here')
+ break
+
+ count = len(runs)
+
result = {'runs': runs}
succeeded = [r for r in runs if ('seconds' in r or 'iops' in r)]
--
2.29.2
- [PATCH v3 0/9] simplebench improvements, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 7/9] simplebench/bench-backup: add --count and --no-initial-run, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 4/9] simplebench/bench-backup: add target-cache argument, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 5/9] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 1/9] simplebench: bench_one(): add slow_limit argument,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 3/9] simplebench/bench-backup: add --compressed option, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 6/9] simplebench/bench-backup: support qcow2 source files, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 2/9] simplebench: bench_one(): support count=1, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 8/9] simplebench/bench-backup: add --drop-caches argument, Vladimir Sementsov-Ogievskiy, 2021/03/23
- [PATCH v3 9/9] MAINTAINERS: update Benchmark util: add git tree, Vladimir Sementsov-Ogievskiy, 2021/03/23