[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str() |
|
Date: |
Tue, 23 Mar 2021 09:13:33 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> check_name_str() masks leading digits when passed enum_member=True.
> Only check_enum() does. Lift the masking into check_enum().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/expr.py | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 11/28] qapi: Move uppercase rejection to check_name_lower(), (continued)
- [PATCH 02/28] tests/qapi-schema: Drop redundant flat-union-inline test, Markus Armbruster, 2021/03/23
- [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str(), Markus Armbruster, 2021/03/23
- [PATCH 14/28] qapi: Enforce type naming rules, Markus Armbruster, 2021/03/23
- [PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions, Markus Armbruster, 2021/03/23
- [PATCH 06/28] tests/qapi-schema: Tweak to demonstrate buggy member name check, Markus Armbruster, 2021/03/23