[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action |
Date: |
Fri, 26 Mar 2021 18:29:37 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
26.03.2021 18:18, Valeriy Vdovin wrote:
Also, we have implementation of qmp_query_cpu_* commands in different
architectures.. Probably we'll need add some stubs for the new command as well.
Currently I do not have a clear idea of how we could do this, because cpuid is
very specific to x86. Other cpu architectures also have cpu
identification means that could be close to x86 cpuid, but not as close to
easily generalize this method. But I'm willing to hear out a
good advice on this topic.
I mean, that I'm afraid, that after your patch QEMU will not compile for other
architectures, as it will say "no such qmp_query_model_cpuid function".
Probably I'm wrong. If I'm right, we'll need a stub implementation for other
architectures, like
qmp_query_model_cpuid(Error **errp)
{
error_setg(errp, "Not implemented");
}
--
Best regards,
Vladimir