[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in re
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt() |
|
Date: |
Fri, 26 Mar 2021 19:49:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/26/21 2:34 PM, Peter Maydell wrote:
> ping for review?
FYI:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html
> On Fri, 19 Mar 2021 at 16:24, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> In commit 81b3ddaf8772ec we fixed a use of uninitialized data
>> in read_tcnt(). However this change wasn't enough to placate
>> Coverity, which is not smart enough to see that if we read a
>> 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot
>> be a flow of execution through the switch default. Add explicit
>> default cases which assert that they can't be reached, which
>> should help silence Coverity.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> hw/timer/renesas_tmr.c | 4 ++++
>> 1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>