Re: [PATCH] tap-bsd: Remove special casing for older OpenBSD releases

[Jason Wang]

在 2021/3/27 上午7:49, Brad Smith 写道:
> OpenBSD added support for tap(4) 10 releases ago.
>
> Remove the special casing for older releases.
>
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 77aaf674b1..59dfcdfae0 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -35,10 +35,6 @@
>   #include <net/if_tap.h>
>   #endif
>   
> -#if defined(__OpenBSD__)
> -#include <sys/param.h>
> -#endif
> -
>   #ifndef __FreeBSD__
>   int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
>                int vnet_hdr_required, int mq_required, Error **errp)
> @@ -59,11 +55,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
>           if (*ifname) {
>               snprintf(dname, sizeof dname, "/dev/%s", ifname);
>           } else {
> -#if defined(__OpenBSD__) && OpenBSD < 201605


I am not sure this sis correct. My understanding is that we still need 
to use tun for old OpenBSD release.

Thanks


> -            snprintf(dname, sizeof dname, "/dev/tun%d", i);
> -#else
>               snprintf(dname, sizeof dname, "/dev/tap%d", i);
> -#endif
>           }
>           TFR(fd = open(dname, O_RDWR));
>           if (fd >= 0) {